Summary:
Using replace for DesktopProtocol::prepareUDSEntry(), as we have
no guarantee that certain fields are not set elsewhere in the call chain
Test Plan: Both kio-slave still work
Reviewers: #plasma, chinmoyr
Reviewed By: chinmoyr
Subscribers: chinmoyr, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18632
Summary:
During porting to the new KIO::SlaveBase::listEntry() API accidentally
the listEntry(entry, true) was turned into a listEntry(), where it
should have been just removed in favour of an existing finished() call.
See 0853202b0c
Test Plan: applications: and programs: no longer show the last entry twice
Reviewers: #plasma, chinmoyr
Reviewed By: chinmoyr
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18641
Summary:
This patch makes the wallpaper chooser grid view delegates show the wallpaper's
title (if it has a desktop file) or filename (if it doesn't). Authorship information
is shown via a tooltip, if present.
Test Plan:
{F6587535, size=full}
{F6587536, size=full}
Reviewers: #vdg, #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18737
Summary:
QML shadows aren't supported with software rendering, so the white text often has poor readability.
This patch falls back to outlines when using software rendering to ensure adequate readability.
BUG: 398317
FIXED-IN: 5.15.0
Test Plan:
No visual change with hardware rendering of some sort.
When forcing software rendering, I get outlines instead of shadows
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18733
Summary: D18678 changes the Notifications KCM's icon. This patch uses that same icon in the Notifications widget in places where clicking on it will open the KCM.
Test Plan: {F6586488, size=full}
Reviewers: broulik, #plasma
Reviewed By: broulik, #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18723
Summary:
Update and improve some old Breeze Look and Feel theme previews (the Breeze Dark previews will be updated in a different revision, because they are in a different repo).
{F6584513}
Test Plan: Open the Look and Feel KCM and the Splash Screen KCM.
Reviewers: #plasma, #vdg, ngraham
Reviewed By: #vdg, ngraham
Subscribers: abetts, ngraham, rooty, #vdg, plasma-devel, #plasma
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18681
Summary:
If having the need to use those settings with something else than the
default, one also expects the utils to follow those custom settings.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18625
Summary:
Setting an overlay by name results in a QIcon for it created; OTOH,
this icon is never used to create the final image in case the
main/attention icons are set by name too.
Since KIconEngine supports overlays natively, directly pass the list of
overlays (with just one element -- the overlay set) to it. As result,
main/attention icons by name are created directly with the requested
overlay by name.
Test Plan:
- builds fine
- main/attention icon by name + overlay by name works now, showing the requested overlay
- main/attention icon by name + overlay by pixmap still works as before
- main/attention icon by pixmap is unaffected, no matter whether/which overlay is set
- the system tray icons of juk, and amarok now have the play/pause overlays
Reviewers: apol
Reviewed By: apol
Subscribers: davidedmundson, apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D17983