Summary:
This allows us to use the new consistent appearance introduced with D29074.
Depends on D29074
Test Plan: {F8273822}
Reviewers: #plasma, #kirigami
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D29075
GHNS Quick Button signals changedEntriesChanged initially even if nothing changed.
While this is a bug that should be fixed in GHNS, the wallpaper model didn't handle the case well,
when the model was reloaded while a preview was being generated.
It looks up whether a preview exists by QUrl and stores a QPersistentModelIndex.
However, when the model is reloaded and it accesses data for the same QUrl, the job might still be in-flight,
but the QPersistentModelIndex is invalid as the model has been reset.
This fixes it by performing all lookups exclusively on QPersistentModelIndex.
The hash lookup is optimized for data() (loads of accesses) with the slower key() lookup being done only
when the less frequently occurring thumbnail generation finishes/fails.
It will now do two preview jobs initially, but at least it shows something again...
BUG: 419234
FIXED-IN: 5.18.4
Differential Revision: https://phabricator.kde.org/D28420
Summary:
Instead of loading the model and then showing the last shown image, we can show
it early so that we signal "wallpaper.loading = false" earlier.
CCBUG: 371455
Test Plan: Have massive slideshow, login
Reviewers: davidedmundson, broulik, #plasma
Reviewed By: davidedmundson, #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27084
Summary: According to Qt docs, QUuid() creates a null UUID object.
Test Plan: N/A, plasmashell is very unstable with Qt 5.15.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27237
Summary:
plasma.kde.org doesn't exist anymore and causes the appstream test to
to fail.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27304
Summary:
now look and feel packages can specify a default image wallpaper.
when a new containment is created at first plasma start or at activity creation
search for a default wallpaper inthe order:
look and feel package
if fails, from the plasma theme
we are sure to find a default after it as if neither of those specify one,
the wallpaper specified by the breeze plasma theme (Next) will be used
D21225 takes care of setting the wallpaper when a lnf theme is selected by the kcm
Test Plan:
tested to start plasma with an empty config file with different themes
that do or don't include wallpapers
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: kossebau, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21226
Summary:
now look and feel packages can specify a default image wallpaper.
when a new containment is created at first plasma start or at activity creation
search for a default wallpaper inthe order:
look and feel package
if fails, from the plasma theme
we are sure to find a default after it as if neither of those specify one,
the wallpaper specified by the breeze plasma theme (Next) will be used
D21225 takes care of setting the wallpaper when a lnf theme is selected by the kcm
Test Plan:
tested to start plasma with an empty config file with different themes
that do or don't include wallpapers
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: kossebau, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21226
If we have this feature now, let's use it and give the wallpaper authors the credit they deserve rather than being tucked away in the tooltip.
Differential Revision: https://phabricator.kde.org/D26531
Summary:
- Correct the destination path when downloading images.
- Switch from FileCopyJob to CopyJob to allow showing file overwrite dialog.
BUG: 379469
Test Plan: Drop files from Firefox to the desktop to set the wallpaper successfully.
Reviewers: #plasma, mart, ngraham
Reviewed By: #plasma, mart, ngraham
Subscribers: mart, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26525
Summary:
BUG: 415461
FIXED-IN: 5.18.0
Depends on D26510
Right now when you first change the wallpaper plugin to slideshow, no locations are
pre-configured, so you have to add one yourself. This patch adds a
`preferred:wallpaperlocations` token as the default that gets replaced in the user's
config file at runtime with the XDG wallpaper locations.
Test Plan:
Log in as new user > right-click desktop > configure > change to slideshow wallpaper
See that`/usr/share/wallpapers` is already in the list of wallpaper locations; how nice
Reviewers: #plasma, #vdg, ndavis, davidedmundson
Reviewed By: #plasma, #vdg, ndavis, davidedmundson
Subscribers: davidre, broulik, davidedmundson, ndavis, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26483
Summary:
This switches the image plugin to using KNewStuffQuick instead of
launching the widget dialog through that ol' widget dialog hack.
It further uses the big preview mode by default, which just seems
to make a lot of sense for wallpapers.
Test Plan:
Without: Uses the old dialog
With: Uses the new dialog, as seen below
{F7882885}
Reviewers: mart, #plasma, ngraham
Reviewed By: mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26665
Summary: It was reported by Victor Ryzhykh that this patch fixes localization of the wallpaper slideshow config window.
Test Plan:
1. Open the config window in some ~100%-translated locale (ca, pt, sv, uk).
2. All messages should be translated.
Reviewers: #plasma, #localization, ngraham
Reviewed By: ngraham
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26584
Summary:
When multiple paths that end in the same folder name are added (for example with D26483),
currently the list shows multiple identical entries distinguished only by their different
tooltips. This patch improves the situation by putting the path to the folder in a
subtitle.
Test Plan:
Before: {F7868784}
After: {F7868785}
Reviewers: #vdg, #plasma, mart
Reviewed By: #vdg, #plasma, mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26510
Summary: They look a little nicer this way, and can be localized more easily.
Test Plan:
Before: {F7871094, size=full}
After:{F7871093, size=full}
Reviewers: #vdg, #plasma, mart
Reviewed By: #vdg, #plasma, mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26529
Summary:
Right now, when there are no configured wallpaper slideshow paths or wallpapers in the
slideshow, the list and grid (respectively) are just empty. This patch adds some
placeholder labels to let the user know that it's not broken, just like we do in the
Thunderbolt KCM.
See one `FIXME:` in the code that I could use a hand with.
Test Plan: {F7870947}
Reviewers: #vdg, #plasma, mart
Reviewed By: #vdg, #plasma, mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26528
Summary:
The wallpaper knsrc file file assumes that `qdbus` is in $PATH. However this is not
guaranteed; the command lives in the Qt binaries dir which is not typically in $PATH,
and distros typically create symlinks with different names in `/usr/bin`, but not all
create a second compatibility symlink at `/usr/bin/qdbus` that points to the version
for the current Qt version.
Therefore, we should find the command in the Qt binaries dir itself rather than relying
on these compatibility symlinks.
Test Plan: See that the knsrc file now has the absolute path to `qdbus` in it
Reviewers: davidedmundson, fvogt, #plasma, apol
Reviewed By: apol
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25884
Summary:
This is full of mixed bindings/signal handlers for properties and of
broken references in here!
There's likely more to do, but those were the most obvious ones when
working on the screenlocker KCM.
Reviewers: #plasma, mart, davidedmundson, crossi, bport
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25567
Summary:
The file path of the main script is hard-coded to ui/main.qml, so setting
X-Plasma-MainScript is pointless.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25201
Summary:
The TableView in digital clock widget time zone configuration is replaced with ListView. Other UI didn't change.
{F7635385}
Reviewers: #plasma, #plasma_workspaces, ngraham
Reviewed By: ngraham
Subscribers: GB_2, ahiemstra, broulik, kmaterka, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24798
Summary:
There was a concious decision that when we add a new wallpaper we should
append to the existing random order collection, rather than shuffle
existing ones.
The logic is fine but if we start with 0 wallpapers and then add 20 new
ones we don't shuffle anything.
This patch changes it so when a new batch of N wallpapers is added,
those N are shuffled when appending to the existing sort order.
BUG: 413463
FIXED-IN: 5.17.2
Test Plan: qDebug + ran a few times
Reviewers: #plasma, ngraham, davidre
Reviewed By: ngraham, davidre
Subscribers: davidre, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24986
Summary:
Otherwise when we randomise the wallpaper order we will always get the
same results.
CCBUG: 413463
Test Plan: qDebug + ran twice
Reviewers: #plasma, ngraham, davidre
Reviewed By: ngraham, davidre
Subscribers: davidre, apol, anthonyfieroni, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24985
Summary:
QSortFilterProxyModel uses std::stable_sort internally which requires that the
comparison function generates a strict weak ordering. Returning true or false
randomly didn't fullfil this requirement causing a crash in some calls to invalidate.
To keep the random order consistent a vector of row indices is used which records
the current random order.
BUG: 413018
FIXED-IN: 5.17.1
Test Plan:
To reproduce the bug use a slideshow in random order with few pictures and a small
time intervall.
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: davidedmundson, broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24723
Summary:
Allows setting of other sorting orders like alphabetical or last modified date.
To enable this a new ProxyModel is introduced which handles the sorting and
filtering (as indicated by the checkboxes). This is backed by the slideshowModel
whcih previously as only used for the configutation. The lists of slides and unseen
slides are dropped as now the slides that are shown are taken from the model.
FEATURE: 186181
FIXED-IN: 5.17.0
Test Plan:
{F6938259}
{F6938260}
{F6938261}
{F6938263}
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D22121
l10n daemon script
Daan De Meyer
Nate Graham
Kai Uwe Broulik
Albert Astals Cid
David Redondo
Vlad Zahorodnii
Heiko Becker
Marco Martin
Tranter Madi
Dan Leinir Turthra Jensen
Yuri Chornoivan
Laurent Montel
Kevin Ottens
Vlad Zahorodnii
Guo Yunhe
David Edmundson