This commit implements what was agreed upon in
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/690, but
does it correctly by simply disabling the menu item by default, not
removing it entirely. This ensures that the change is only made for new
installs. Existing users' configs will not be touched (because all
values are serialized to the config file already), and any new users
will be able to re-enable this item if they like it.
CCBUG: 437747
This reverts commit 1cb254416c.
This change was not implemented in the correct way. The context menu is
configurable, so instead of removing the possibility of the menu item
ever being in the menu, we should have simply removed it from the
default set of menu items.
BUG: 437747
FIXED-IN: 5.22
The KWin setting for whether or not to wrap around was not respected, so
wrap was always true even if the user has turned it off. This commit
fixes that.
BUG: 425787
In the past, this was considered to be a way to make KRunner more
discoverable by users.
However today Kickoff exposes all the same runners as KRunner, so its
full functionality is therefore more discoverable in a different way,
so making the KRunner UI itelf more discoverable is not as important.
Furthermore, this was always a questionable way to increase
discoverability in the first place, because the menu item did not expose
the keyboard shortcut, which is the typical way that people show
KRunner. Also, context menus are generally considered shortcuts for
experts; novice users don't tend to use context menus very much. But
experts are the people more likely to already know about KRunner and its
keyboard shortcut, and would never invoke it using the desktop context
menu.
Removing this menu item de-clutters the desktop context menu a bit, and
we do get complaints that the menu is overwhelming because it has too
many things in it. This is a fairly unimportant item that we can remove
without any real consequences.
Finally, Marco didn't like the change to refer to KRunner using the
actual term "KRunner" in the main UI, so this change removes one of the
two places where that happened. :)
We do this sometimes, but not consistenly.
The benefit is twofold.
First it improves the diff when adding new values since no existing line needs to be touched.
Second it prevents clang-format from collapsing the definition into a single line, which is undesired for large enums.
It can apparently happen that virtual desktops is empty at a given point
in time. Potentially due to other bugs on the system.
Calls to desktopIds.at(N) will fail.
BUG: 427106
This came up in today's VDG meeting. A user who right-clicks on the
desktop is highly likely to want to change the wallpaper, but the menu
item that does this is the last item in the menu, not the first. We can
move it up to the top.
The "Open with Dolphin" item is likewise moved up too so that we don't
have two single-item sections in a row.
Summary:
In Plasma, 5.18, this ishn't a user-facing option anymore. It's still visible in the
context meny configuration dialog though, and it's still referenced in some of the
context menu building code.
This patch removes it from those places
BUG: 416578
FIXED-IN: 5.18.0
Test Plan:
Context menu still looks the same on the desktop and panel, both in and out of edit mode
The action no longer shows up in the configuration UI.
Please review carefully as this code is fairly unfamiliar to me.
Reviewers: mart, #plasma
Reviewed By: mart, #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26845
Summary:
ContainmentActions had some old windows code was dropped as that's
clearly unused.
logout and leave actions now enable/disable at runtime, so in future can
respond to config changes when that's added to libkworkspace.
DataEngines and the krunner code should have no visible changes
Test Plan:
Left from the desktop and from krunner
Changed the default action in ksmserver's kcm
Confirmed that changes the default leave action changed
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21764
Alexander Lohnau
Adrien Faveraux
l10n daemon script
Nicolas Fella
Nate Graham
Felipe Kinoshita
Yuri Chornoivan
David Edmundson