Component.onCompleted blocks were unnecessary and redundant.
This patch also cleans up QML code style, and swaps visible/text lines to
make both buttons code more similar.
It used to cause an error like this:
[03:21:31.246] (WW) GREETER: file:///usr/share/sddm/themes/breeze/KeyboardButton.qml:19: TypeError: Cannot read property 'shortName' of null
We already force focus to the password field after showing or hiding the
virtual keyboard, since otherwise it's annoying and you have to manually
re-focus it. Let's do the same for the session and keyboard layout
choosers to save the user a click and some annoyance.
BUG: 451361
FIXED-IN: 5.25
There were three principal sources of errors and warnings:
1. Un-ported `onFooChanged` statements
2. `config.fontSize` being unconditionally referenced from components
without access to it (it comes from the SDDM config)
3. Accessing units from the context property rather than the singleton
All are fixed now. Tested with:
1. `sddm-greeter --test-mode --theme ~/kde/usr/share/sddm/themes/breeze/`
2. `~/kde/usr/lib64/libexec/kscreenlocker_greet --testing --theme ~/kde/src/plasma-workspace/lookandfeel`
3. `/kde/usr/lib64/libexec/ksmserver-logout-greeter --fakearg`
No regressions found.
BUG: 425349
FIXED-IN: 5.20
This begins the process of porting plasma-workspace to PlasmaComponents3. At
this point, only the relatively easy work is done. Every file not ported
now has been given the reason for still using PC2 in a comment on the import
line so you can see at a glance what the blocker is by running
`grep -r "org.kde.plasma.components 2.0"` in the repo.
Everything is tested and there are no breakages or functional regressions. In
the process, a few unused imports are removed.
Here are the remaining PC3 omissions blocking what's left from getting easily
ported:
- No Highlight
- No ListItem
- No PageStack
- No ContextMenu
- No QueryDialog
- No ModelContextMenu
- TabBar has no left and right tab states
- ToolButton has no built-in method to show a menu when clicked
This reverts commit 5c8ce892e3.
Due to the looming LTS release date and bugs (415098, 414873, 4145094, 414852) that keep piling up, we are reverting the QQC2 and PC3 port of the SDDM theme.
Summary:
The TableView in digital clock widget time zone configuration is replaced with ListView. Other UI didn't change.
{F7635385}
Reviewers: #plasma, #plasma_workspaces, ngraham
Reviewed By: ngraham
Subscribers: GB_2, ahiemstra, broulik, kmaterka, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24798
Summary: Components that used QQC1 in `sddm-theme/` (excluding the symlinked `components` folder) have been changed to use QQC2.
Test Plan:
Ensure no loss of functionality, style, or bugs from the port of QQC1 to QQC2.
{F7256235}
Reviewers: #plasma, #vdg, davidedmundson, filipf
Reviewed By: #plasma, #vdg, davidedmundson, filipf
Subscribers: ndavis, GB_2, ngraham, filipf, davidedmundson, plasma-devel
Tags: #plasma
Maniphest Tasks: T10958
Differential Revision: https://phabricator.kde.org/D21815
Summary:
The session selector's and keyboard layout's menus are now styled to resemble the Breeze theme rather than the default QML style.
BUG: 408702
Test Plan: Ensure the styling looks good regardless of various conditions. (resolution, dpi, distro, amount of sessions, etc.)
Reviewers: #vdg, filipf
Reviewed By: #vdg, filipf
Subscribers: apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21794
Summary:
This patch:
- tells the login screen to modify the font size specified in theme.conf and the lock screen to modify the user's default theme's font size instead
- makes sure that the login screen session and keyboard buttons take this new approach too
- raises the font size of "Start New Session" on the lock screen (to match the rest)
- raises the artist/track font sizes (to match the password field)
Test Plan:
This patch resolves the problem of
(1) The fonts on the login screen and
{F6676520}
(2) the fonts on the lock screen
{F6676524}
not having matching sizes.
Reviewers: #vdg, #plasma, ngraham, filipf
Reviewed By: #vdg, ngraham, filipf
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Maniphest Tasks: T10325
Differential Revision: https://phabricator.kde.org/D19631
Summary:
Implements the new SDDM theme
Code is written with the intention to easily port the lock screen
All SDDM related code is now shifted into Main with Login.qml acting as
an abstraction layer.
Test Plan: Ran it, against the awesome mock data.
Reviewers: #plasma, mart
Reviewed By: mart
Subscribers: bshah, mart, apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2399
Summary:
Currently we install sddm theme twice, once where sddm expects theme and
another in look&feel package. This duplicate installation is not really
a good idea because one in look-and-feel is completely unused.
Reviewers: davidedmundson, mart, sitter
Reviewed By: sitter
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2351
Summary: Implemented the new login screen as designed by Andreas
Test Plan: As there is a dummydata folder, simply run qmlscene Main.qml
to test
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D1670
ivan tkachenko
Aleix Pol
Nate Graham
Filip Fila
Guo Yunhe
Carson Black
Krešimir Čohar
David Edmundson
Bhushan Shah