We do this sometimes, but not consistenly.
The benefit is twofold.
First it improves the diff when adding new values since no existing line needs to be touched.
Second it prevents clang-format from collapsing the definition into a single line, which is undesired for large enums.
Summary:
This makes it work on Wayland. And probably fixes bugs, the code,
especially the next/prev window stuff, was pretty wonky.
Also some general cleanup.
Depends on D13745.
Reviewers: mart, davidedmundson
Reviewed By: davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Maniphest Tasks: T4457
Differential Revision: https://phabricator.kde.org/D15642
Summary:
Unfortunately this alone won't make it work on Wayland, as it's
still based around storing X11 window ids in QActions.
For it to work on Wayland, it should store model indices instead.
However that requires us to be able to refresh contextualActions()
while the menu is open, which the Plasma framework does not yet
allow.
We obviously need to address this later. For now, let's drop
the old backend and save some CPU and memory.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2165
Summary:
Also ports in-module users of the library.
Translation domain and pot file name remain unchanged, as the new lib
contains no strings.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D1721
This is the beginning of revision history for this module. If you
want to look at revision history older than this, please refer to the
techbase wiki for how to use Git history grafting. At the time of
writing, this wiki is located here:
http://community.kde.org/Frameworks/GitOldHistory
If you have already performed the grafting and you don't see any
history beyond this commit, try running "git log" with the "--follow"
argument.
Branched from the monolithic repo kde-workspace, frameworks branch, at commit
049113e719dd2fc4446d054fa1a3aada330094f0
Laurent Montel
Alexander Lohnau
Adrien Faveraux
Nicolas Fella
Eike Hein
Aleix Pol
Marco Martin