Summary: Include duplication, no newline at the end of file and missing argument to the i18n() call
Test Plan: Should work fine but needs a review for i18n() calls
Reviewers: #plasma, apol
Reviewed By: apol
Subscribers: apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24580
Summary:
Since Plasma 5.16, clicks over the icons are frequently ignored. See https://bugs.kde.org/show_bug.cgi?id=408748 for more info. This patch is an attempt to fix that seems to work for me.
BUG: 408748
Reviewers: ngraham, trmdi, #plasma, hein
Reviewed By: ngraham, #plasma, hein
Subscribers: hein, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D22306
Summary:
This is one of the tasks on the Plasma 5.9 release todo, as
agreed at the kick-off meeting. Dashboard is about enabling
an alternative fullscreen workflow for people who want one,
and this extends the coverage to widget management. It's also
a widget management workflow many people are used to from
their phone.
This is quite early code, but already works fairly nicely.
There's even polish like pre-loading the widget explorer model
as soon as the tab is hovered to speed up the tab switch, and
keyboard nav is working, too.
I would like to get it reviewed now and merged once egregious
technical founds are identified and eliminated. Please don't
be too picky on the visual or even workflow details - one
reason I want it merged early is so that I can get it into
the VDG's hands via Neon for advice, and also because I want
people to spend some time using it in general. It's early
enough in the 5.9 cycle to iterate more.
In addition to the attached screenshot, here is a video demo:
https://www.youtube.com/watch?v=ajIzfU0eJtI
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D3200
Detaching drag initiation from the delegate avoids mouse events
getting dropped as hover-enabled items move in response to the
drag (as a bonus it will also avoid a crash in case of a sycoca
update mid-drag).
This version is a mostly-from-scratch reimplementation of
the Plasma 1 version.
Some minor-in-scope loose ends are left, both external and
internal to the code; check TODO for whether your issue is
already known.
Laurent Montel
Alexander Lohnau
Yuri Chornoivan
Bhushan Shah
Luca Carlon
Eike Hein
Kai Uwe Broulik