From 774a23fc0a7c112f86193ee6e07947fee6282ef4 Mon Sep 17 00:00:00 2001 From: Harald Sitter Date: Tue, 20 Jun 2017 10:28:37 +0200 Subject: [PATCH] fix attachment signals Signals did not get changed for Qt5 porting but no one ever noticed because they were still in stringy runtime eval syntax :S Using proper signals to connect to fixes attaching a new backtrace to an existing bug. Backport of fix from D6161. CHANGELOG: Make attaching backtraces to existing bug reports work --- .../reportassistantpages_bugzilla_duplicates.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drkonqi/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp b/drkonqi/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp index 6a4b44fdb..a5bde7821 100644 --- a/drkonqi/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp +++ b/drkonqi/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp @@ -900,8 +900,10 @@ BugzillaReportConfirmationDialog::BugzillaReportConfirmationDialog(int bugNumber "and close the dialog", "Continue")); ui.buttonBox->button(QDialogButtonBox::Ok)->setEnabled(false); - connect(this, SIGNAL(okClicked()) , this, SLOT(proceedClicked())); - connect(this, SIGNAL(cancelClicked()) , this, SLOT(hide())); + connect(this, &BugzillaReportConfirmationDialog::accepted, + this, &BugzillaReportConfirmationDialog::proceedClicked); + connect(this, &BugzillaReportConfirmationDialog::rejected, + this, &BugzillaReportConfirmationDialog::hide); //Set introduction text ui.introLabel->setText(i18n("You are going to mark your crash as related to bug %1",