From e9c72a0420c1dba130ba694f9f40f8c48e1c7ff2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Feber?= Date: Mon, 29 Apr 2019 17:40:19 +0200 Subject: [PATCH] Add SDDM theme login load feedback Summary: Currently, when you log in you can see a short freeze which looks bad. This patch adds some feedback by disabling and reducing the opacity of the controls after you begin the login (a busy cursor wouldn't work well, because it only changes when you move the mouse). {F6800357} Test Plan: Log in to a user. Reviewers: #plasma, #vdg, ngraham Reviewed By: #vdg, ngraham Subscribers: ngraham, #vdg, plasma-devel, #plasma Tags: #plasma Differential Revision: https://phabricator.kde.org/D20902 --- sddm-theme/Login.qml | 4 ++++ sddm-theme/Main.qml | 3 +++ 2 files changed, 7 insertions(+) diff --git a/sddm-theme/Login.qml b/sddm-theme/Login.qml index ca881e0ab..0e973a94b 100644 --- a/sddm-theme/Login.qml +++ b/sddm-theme/Login.qml @@ -37,6 +37,10 @@ SessionManagementScreen { var username = showUsernamePrompt ? userNameInput.text : userList.selectedUser var password = passwordBox.text + footer.enabled = false + mainStack.enabled = false + userListComponent.userList.opacity = 0.5 + //this is partly because it looks nicer //but more importantly it works round a Qt bug that can trigger if the app is closed with a TextField focused //DAVE REPORT THE FRICKING THING AND PUT A LINK diff --git a/sddm-theme/Main.qml b/sddm-theme/Main.qml index 84689448b..46ab3932a 100644 --- a/sddm-theme/Main.qml +++ b/sddm-theme/Main.qml @@ -444,6 +444,9 @@ PlasmaCore.ColorScope { target: sddm onLoginFailed: { notificationMessage = i18nd("plasma_lookandfeel_org.kde.lookandfeel", "Login Failed") + footer.enabled = true + mainStack.enabled = true + userListComponent.userList.opacity = 1 } onLoginSucceeded: { //note SDDM will kill the greeter at some random point after this