From c56e12cc540dce44985fa4b6dbe3a31f2e2cd72d Mon Sep 17 00:00:00 2001
From: Cyril Rossi <cyril.rossi@enioka.com>
Date: Tue, 25 Feb 2020 17:45:21 +0100
Subject: [PATCH] libnotificationmanager : add app-specific kconfig settings

Summary: Provide a kcfg for app-specific notifications with kconfig. Require D27059 and D27133

Reviewers: ervin, broulik, bport, meven

Reviewed By: ervin, bport, meven

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27155
---
 libnotificationmanager/CMakeLists.txt         |  2 ++
 .../kcfg/behaviorsettings.kcfg                | 24 +++++++++++++++++++
 .../kcfg/behaviorsettings.kcfgc               | 10 ++++++++
 libnotificationmanager/plasmanotifyrc         |  3 ++-
 4 files changed, 38 insertions(+), 1 deletion(-)
 create mode 100644 libnotificationmanager/kcfg/behaviorsettings.kcfg
 create mode 100644 libnotificationmanager/kcfg/behaviorsettings.kcfgc

diff --git a/libnotificationmanager/CMakeLists.txt b/libnotificationmanager/CMakeLists.txt
index f3e480338..facc5ee6c 100644
--- a/libnotificationmanager/CMakeLists.txt
+++ b/libnotificationmanager/CMakeLists.txt
@@ -42,6 +42,7 @@ kconfig_add_kcfg_files(notificationmanager_LIB_SRCS kcfg/donotdisturbsettings.kc
 kconfig_add_kcfg_files(notificationmanager_LIB_SRCS kcfg/notificationsettings.kcfgc GENERATE_MOC)
 kconfig_add_kcfg_files(notificationmanager_LIB_SRCS kcfg/jobsettings.kcfgc GENERATE_MOC)
 kconfig_add_kcfg_files(notificationmanager_LIB_SRCS kcfg/badgesettings.kcfgc GENERATE_MOC)
+kconfig_add_kcfg_files(notificationmanager_LIB_SRCS kcfg/behaviorsettings.kcfgc GENERATE_MOC)
 
 # DBus
 # Notifications
@@ -97,6 +98,7 @@ install(FILES
     ${CMAKE_CURRENT_BINARY_DIR}/notificationsettings.h
     ${CMAKE_CURRENT_BINARY_DIR}/jobsettings.h
     ${CMAKE_CURRENT_BINARY_DIR}/badgesettings.h
+    ${CMAKE_CURRENT_BINARY_DIR}/behaviorsettings.h
     ${CMAKE_CURRENT_BINARY_DIR}/notificationmanager_export.h
     DESTINATION ${KDE_INSTALL_INCLUDEDIR}/notificationmanager COMPONENT Devel
 )
diff --git a/libnotificationmanager/kcfg/behaviorsettings.kcfg b/libnotificationmanager/kcfg/behaviorsettings.kcfg
new file mode 100644
index 000000000..31d74218c
--- /dev/null
+++ b/libnotificationmanager/kcfg/behaviorsettings.kcfg
@@ -0,0 +1,24 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<kcfg xmlns="http://www.kde.org/standards/kcfg/1.0"
+      xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+      xsi:schemaLocation="http://www.kde.org/standards/kcfg/1.0
+                          http://www.kde.org/standards/kcfg/1.0/kcfg.xsd" >
+    <kcfgfile name="plasmanotifyrc">
+        <parameter name="GroupEntry" />
+        <parameter name="DesktopEntry"/>
+    </kcfgfile>
+    <group name="$(DesktopEntry)" parentGroupName="$(GroupEntry)">
+        <entry name="ShowPopups" type="Bool">
+            <default>true</default>
+        </entry>
+        <entry name="ShowPopupsInDndMode" type="Bool">
+            <default>false</default>
+        </entry>
+        <entry name="ShowInHistory" type="Bool">
+            <default>true</default>
+        </entry>
+        <entry name="ShowBadges" type="Bool">
+            <default>true</default>
+        </entry>
+    </group>
+</kcfg>
diff --git a/libnotificationmanager/kcfg/behaviorsettings.kcfgc b/libnotificationmanager/kcfg/behaviorsettings.kcfgc
new file mode 100644
index 000000000..30472f54c
--- /dev/null
+++ b/libnotificationmanager/kcfg/behaviorsettings.kcfgc
@@ -0,0 +1,10 @@
+File=behaviorsettings.kcfg
+NameSpace=NotificationManager
+ClassName=BehaviorSettings
+Visibility=NOTIFICATIONMANAGER_EXPORT
+IncludeFiles=\"notificationmanager_export.h\"
+Mutators=true
+DefaultValueGetters=true
+Notifiers=true
+GenerateProperties=true
+ParentInConstructor=true
diff --git a/libnotificationmanager/plasmanotifyrc b/libnotificationmanager/plasmanotifyrc
index 89322a624..41f1517bb 100644
--- a/libnotificationmanager/plasmanotifyrc
+++ b/libnotificationmanager/plasmanotifyrc
@@ -17,4 +17,5 @@ ShowInHistory=false
 # Non-configurable applications don't deserve to be in history by default
 [Applications][@other]
 ShowInHistory=false
-ShowBadges=false # wouldn't work anyway
+# Badges wouldn't work anyway
+ShowBadges=false