From b576ebf059f42c610184695727801aa615866bd7 Mon Sep 17 00:00:00 2001 From: Harald Sitter Date: Mon, 3 Jan 2022 09:17:54 +0100 Subject: [PATCH] dry up code instead of repeating the removable conditional use an intermediate function --- .../package/contents/ui/DeviceItem.qml | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/applets/devicenotifier/package/contents/ui/DeviceItem.qml b/applets/devicenotifier/package/contents/ui/DeviceItem.qml index 93569e20c..fc06df27b 100644 --- a/applets/devicenotifier/package/contents/ui/DeviceItem.qml +++ b/applets/devicenotifier/package/contents/ui/DeviceItem.qml @@ -55,18 +55,14 @@ PlasmaExtras.ExpandableListItem { Connections { target: unmountAll function onClicked() { - if (model["Removable"] && isMounted) { - actionTriggered(); - } + removableActionTriggered(); } } Connections { target: plasmoid.action("unmountAllDevices") function onTriggered() { - if (model["Removable"] && isMounted) { - actionTriggered(); - } + removableActionTriggered(); } } @@ -106,6 +102,12 @@ PlasmaExtras.ExpandableListItem { QQC2.Action { } } + function removableActionTriggered() { + if (model["Removable"] && isMounted) { + actionTriggered(); + } + } + function actionTriggered() { var service var operationName