From aa20144814b5b004f317984900a11d877ae22e4e Mon Sep 17 00:00:00 2001 From: David Edmundson Date: Thu, 26 May 2016 14:03:53 +0100 Subject: [PATCH] Port all instances of Kauthorized action/shell_command to shell_command The KAuthorized key to prevent shell access according the documentation is simply "shell_action" not "action/shellAction" so should use authorize not authorizeKAction This appears to have come about as part of a porting bug when going from KApplication::authorize to KAuthorized in kdelibs3 to kdelibs4. To currently block shell access a sysadmin currently needs to have both keys set already, so we can be confident it won't have any actual compatibility problems. --- runners/shell/shellrunner.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/runners/shell/shellrunner.cpp b/runners/shell/shellrunner.cpp index 00f7885f7..25661af7a 100644 --- a/runners/shell/shellrunner.cpp +++ b/runners/shell/shellrunner.cpp @@ -42,7 +42,7 @@ ShellRunner::ShellRunner(QObject *parent, const QVariantList &args) setObjectName( QLatin1String("Command" )); setPriority(AbstractRunner::HighestPriority); setHasRunOptions(true); - m_enabled = KAuthorized::authorizeKAction(QStringLiteral("run_command")) && KAuthorized::authorizeKAction(QStringLiteral("shell_access")); + m_enabled = KAuthorized::authorize(QStringLiteral("run_command")) && KAuthorized::authorize(QStringLiteral("shell_access")); setIgnoredTypes(Plasma::RunnerContext::Directory | Plasma::RunnerContext::File | Plasma::RunnerContext::NetworkLocation | Plasma::RunnerContext::UnknownType | Plasma::RunnerContext::Help);