From a83d5b21a5cce8444ba811343dba4de3519658de Mon Sep 17 00:00:00 2001 From: Alexander Lohnau Date: Thu, 11 Nov 2021 10:45:42 +0100 Subject: [PATCH] Do not depend on deprecated internal QVariant comparisons Otherwise the build without deprecations does not work anymore. --- containmentactions/switchwindow/switch.cpp | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/containmentactions/switchwindow/switch.cpp b/containmentactions/switchwindow/switch.cpp index 3b12c0903..4b5054bce 100644 --- a/containmentactions/switchwindow/switch.cpp +++ b/containmentactions/switchwindow/switch.cpp @@ -11,6 +11,7 @@ #include "activityinfo.h" #include "tasksmodel.h" #include "virtualdesktopinfo.h" +#include #include #include @@ -108,7 +109,7 @@ void SwitchWindow::makeMenu() return; } - QMultiMap desktops; + QMultiMap desktops; QList allDesktops; // Make all the window actions. @@ -129,9 +130,9 @@ void SwitchWindow::makeMenu() action->setIcon(idx.data(Qt::DecorationRole).value()); action->setData(idx.data(AbstractTasksModel::WinIdList).toList()); - const QVariantList &desktopList = idx.data(AbstractTasksModel::VirtualDesktops).toList(); + const QStringList &desktopList = idx.data(AbstractTasksModel::VirtualDesktops).toStringList(); - for (const QVariant &desktop : desktopList) { + for (const QString &desktop : desktopList) { desktops.insert(desktop, action); } @@ -146,7 +147,7 @@ void SwitchWindow::makeMenu() // Sort into menu(s). if (m_mode == CurrentDesktop) { - const QVariant ¤tDesktop = m_virtualDesktopInfo->currentDesktop(); + const QString ¤tDesktop = m_virtualDesktopInfo->currentDesktop().toString(); QAction *a = new QAction(i18nc("plasma_containmentactions_switchwindow", "Windows"), this); a->setSeparator(true); @@ -160,7 +161,7 @@ void SwitchWindow::makeMenu() if (m_mode == AllFlat) { for (int i = 0; i < desktopIds.count(); ++i) { - const QVariant &desktop = desktopIds.at(i); + const QString &desktop = desktopIds.at(i).toString(); if (desktops.contains(desktop)) { const QString &name = QStringLiteral("%1: %2").arg(QString::number(i + 1), desktopNames.at(i)); @@ -179,7 +180,7 @@ void SwitchWindow::makeMenu() } } else { // Submenus. for (int i = 0; i < desktopIds.count(); ++i) { - const QVariant &desktop = desktopIds.at(i); + const QString &desktop = desktopIds.at(i).toString(); if (desktops.contains(desktop)) { const QString &name = QStringLiteral("%1: %2").arg(QString::number(i + 1), desktopNames.at(i));