From 9aa0bc24eca24e9c7af7e8986e8167ac2f073444 Mon Sep 17 00:00:00 2001 From: Aleix Pol Date: Thu, 9 Sep 2021 02:09:56 +0200 Subject: [PATCH] shell: Just parse the key once --- shell/screenpool.cpp | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/shell/screenpool.cpp b/shell/screenpool.cpp index 89e237be8..b41a2fd7f 100644 --- a/shell/screenpool.cpp +++ b/shell/screenpool.cpp @@ -55,10 +55,11 @@ void ScreenPool::load() const auto keys = m_configGroup.keyList(); for (const QString &key : keys) { QString connector = m_configGroup.readEntry(key, QString()); - if (!key.isEmpty() && !connector.isEmpty() && !m_connectorForId.contains(key.toInt()) && !m_idForConnector.contains(connector)) { - m_connectorForId[key.toInt()] = connector; - m_idForConnector[connector] = key.toInt(); - } else if (m_idForConnector.value(connector) != key.toInt()) { + const int currentId = key.toInt(); + if (!key.isEmpty() && !connector.isEmpty() && !m_connectorForId.contains(currentId) && !m_idForConnector.contains(connector)) { + m_connectorForId[currentId] = connector; + m_idForConnector[connector] = currentId; + } else if (m_idForConnector.value(connector) != currentId) { m_configGroup.deleteEntry(key); } }