From 8b6ad495d0eff343ea6b0ee414092d85b8d40e8e Mon Sep 17 00:00:00 2001 From: Alexander Lohnau Date: Mon, 22 Feb 2021 18:10:08 +0100 Subject: [PATCH] locations runner: Fix empty list on invalid shell quotes --- runners/locations/locationrunner.cpp | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/runners/locations/locationrunner.cpp b/runners/locations/locationrunner.cpp index 175c07023..d2651f3e7 100644 --- a/runners/locations/locationrunner.cpp +++ b/runners/locations/locationrunner.cpp @@ -53,9 +53,12 @@ void LocationsRunner::match(Plasma::RunnerContext &context) { QString term = context.query(); // If we have a query with an executable and optionally arguments, BUG: 433053 - QFileInfo tmpInfo(KShell::tildeExpand(KShell::splitArgs(term).constFirst())); - if (tmpInfo.isFile() && tmpInfo.isExecutable()) { - return; + const QStringList split = KShell::splitArgs(term); + if (!split.isEmpty()) { + QFileInfo tmpInfo(KShell::tildeExpand(split.constFirst())); + if (tmpInfo.isFile() && tmpInfo.isExecutable()) { + return; + } } // We want to expand ENV variables like $HOME to get the actual path, BUG: 358221 KUriFilter::self()->filterUri(term, {QStringLiteral("kshorturifilter")});