From 7ee035acf8382bcbc9f0951142a10c92e3ffc3dd Mon Sep 17 00:00:00 2001 From: David Edmundson Date: Wed, 31 Jul 2019 02:16:08 +0200 Subject: [PATCH] [interactiveconsole] Port KIO code to new connect syntax Summary: It was previously using the old style due to getting downcast too early Test Plan: Compiles Reviewers: #plasma, sitter Reviewed By: sitter Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D22840 --- .../interactiveconsole/interactiveconsole.cpp | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/components/shellprivate/interactiveconsole/interactiveconsole.cpp b/components/shellprivate/interactiveconsole/interactiveconsole.cpp index 904f5b3c1..da817f108 100644 --- a/components/shellprivate/interactiveconsole/interactiveconsole.cpp +++ b/components/shellprivate/interactiveconsole/interactiveconsole.cpp @@ -360,9 +360,10 @@ void InteractiveConsole::loadScriptFromUrl(const QUrl &url) m_job.data()->kill(); } - m_job = KIO::get(url, KIO::Reload, KIO::HideProgressInfo); - connect(m_job.data(), SIGNAL(data(KIO::Job*,QByteArray)), this, SLOT(scriptFileDataRecvd(KIO::Job*,QByteArray))); - connect(m_job.data(), &KJob::result, this, &InteractiveConsole::reenableEditor); + auto job = KIO::get(url, KIO::Reload, KIO::HideProgressInfo); + connect(job, &KIO::TransferJob::data, this, &InteractiveConsole::scriptFileDataRecvd); + connect(job, &KJob::result, this, &InteractiveConsole::reenableEditor); + m_job = job; } } @@ -495,9 +496,10 @@ void InteractiveConsole::saveScript(const QUrl &url) m_job.data()->kill(); } - m_job = KIO::put(url, -1, KIO::HideProgressInfo); - connect(m_job.data(), SIGNAL(dataReq(KIO::Job*,QByteArray&)), this, SLOT(scriptFileDataReq(KIO::Job*,QByteArray&))); - connect(m_job.data(), &KJob::result, this, &InteractiveConsole::reenableEditor); + auto job = KIO::put(url, -1, KIO::HideProgressInfo); + connect(job, &KIO::TransferJob::dataReq, this, &InteractiveConsole::scriptFileDataReq); + connect(job, &KJob::result, this, &InteractiveConsole::reenableEditor); + m_job = job; } }