From 7221ffd1a9aeeae52467ac4b3bc3a5bfcde7a500 Mon Sep 17 00:00:00 2001 From: Nate Graham Date: Wed, 19 Jan 2022 11:06:35 -0700 Subject: [PATCH] applets/systemtray: fix glitch for some applets with headers PlasmoidPopupsContainer.qml has special code to handle merging headers from applets if those applets use a PlasmaComponents3.Page instance as their FullRepresentation. However this breaks for any applets that use PlasmaExtras.Representation, which is a subclass of it that we have been porting applets to over time, because it offers more features in a single location. This caused the detection to break, so such applets woudl have their headers improperly merged. Explicitly detecting the use of PlasmaExtras.Representation as well fixes it. BUG: 438178 FIXED-IN: 5.24 --- .../systemtray/package/contents/ui/PlasmoidPopupsContainer.qml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml b/applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml index ab1296674..80c1e8805 100644 --- a/applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml +++ b/applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml @@ -42,7 +42,8 @@ StackView { activeApplet.fullRepresentationItem.anchors.centerIn = undefined; activeApplet.fullRepresentationItem.anchors.fill = undefined; - if (activeApplet.fullRepresentationItem instanceof PlasmaComponents3.Page) { + if (activeApplet.fullRepresentationItem instanceof PlasmaComponents3.Page || + activeApplet.fullRepresentationItem instanceof PlasmaExtras.Representation) { if (activeApplet.fullRepresentationItem.header && activeApplet.fullRepresentationItem.header instanceof PlasmaExtras.PlasmoidHeading) { mainStack.appletHasHeading = true activeApplet.fullRepresentationItem.header.background.visible = false