From 705ec385df2b6fc0c81b046f4323fbd61baadd26 Mon Sep 17 00:00:00 2001 From: Wolfgang Bauer Date: Thu, 5 Jun 2014 18:21:05 +0200 Subject: [PATCH] kscreenlocker_greet: use SA_RESTART for signal handler As discussed in https://git.reviewboard.kde.org/r/117091/. Not using the SA_RESTART flag might (in theory) cause the greeter to be aborted (because certain syscalls may be interrupted and fail with EINTR). SA_RESTART seems to be the BSD default and is used by "legacy" signal() by default in glibc 2 and later as well anyway. REVIEW: 118563 --- ksmserver/screenlocker/greeter/main.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ksmserver/screenlocker/greeter/main.cpp b/ksmserver/screenlocker/greeter/main.cpp index 4b575ee39..44ea2552f 100644 --- a/ksmserver/screenlocker/greeter/main.cpp +++ b/ksmserver/screenlocker/greeter/main.cpp @@ -98,7 +98,7 @@ int main(int argc, char* argv[]) struct sigaction sa; sa.sa_handler = signalHandler; sigemptyset(&sa.sa_mask); - sa.sa_flags = 0; + sa.sa_flags = SA_RESTART; sigaction(SIGTERM, &sa, nullptr); sigaction(SIGUSR1, &sa, nullptr); return app.exec();