From 419b9708ee9e36c4d5825ff6f58ca71f61d32d83 Mon Sep 17 00:00:00 2001 From: David Edmundson Date: Mon, 11 Nov 2019 16:40:38 +0000 Subject: [PATCH] Fix binding loop in lockscreen media controls Summary: When we load and position the Image the height is constrained, the width is not. The image fillMode is set as PreserveAspectFit so the width will adjust to fit the aspect ratio, Therefore we only want to set a fixed height on the sourceSize, it will automatically match the resultant width. BUG: 413087 FIXED-IN: 5.17.3 Test Plan: I was unable to reproduce the state. Patch is based on reading the code and docs Reviewers: #plasma, broulik, ngraham Reviewed By: #plasma, broulik, ngraham Subscribers: broulik, filipf, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D25252 --- lookandfeel/contents/lockscreen/MediaControls.qml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lookandfeel/contents/lockscreen/MediaControls.qml b/lookandfeel/contents/lockscreen/MediaControls.qml index a4903e377..62d5f7ca1 100644 --- a/lookandfeel/contents/lockscreen/MediaControls.qml +++ b/lookandfeel/contents/lockscreen/MediaControls.qml @@ -100,7 +100,7 @@ Item { asynchronous: true fillMode: Image.PreserveAspectFit source: mpris2Source.albumArt - sourceSize: Qt.size(width, height) + sourceSize.height: height visible: status === Image.Loading || status === Image.Ready }