From 21e56d17d57d2152feb17eecf3bf1dcaea7ebfc2 Mon Sep 17 00:00:00 2001 From: David Edmundson Date: Sun, 13 Oct 2019 17:35:34 +0100 Subject: [PATCH] Extra force Plasma telemetry off by default Original intention was that we would be globally off by default. When enabling it would have a default setting for Plasma ready That doesn't quite work out just yet. See bug for details This is a precautionary temporary fix just to be extra safe CCBUG: 412913 --- kcms/feedback/feedback.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/kcms/feedback/feedback.cpp b/kcms/feedback/feedback.cpp index 8cbf0057c..92bc0caf8 100644 --- a/kcms/feedback/feedback.cpp +++ b/kcms/feedback/feedback.cpp @@ -53,10 +53,11 @@ Feedback::~Feedback() = default; void Feedback::load() { - KUserFeedback::Provider p; + setFeedbackEnabled(m_globalConfig->group("UserFeedback").readEntry("Enabled", false)); - setFeedbackEnabled(m_globalConfig->group("UserFeedback").readEntry("Enabled", p.isEnabled())); - setPlasmaFeedbackLevel(m_plasmaConfig->group("Global").readEntry("FeedbackLevel", int(KUserFeedback::Provider::BasicUsageStatistics))); + // See 412913. global killswitch is off by default, therefore globally we're enabled by default :/ + // default to Plama off by default until that situation is resolved to be double sure no user accidentally sends anything + setPlasmaFeedbackLevel(m_plasmaConfig->group("Global").readEntry("FeedbackLevel", int(KUserFeedback::Provider::NoTelemetry))); setNeedsSave(false); }