From 1cc60d23db16c62ddf8131b4155f31a91e269911 Mon Sep 17 00:00:00 2001 From: Kai Uwe Broulik Date: Sat, 27 Mar 2021 11:27:20 +0100 Subject: [PATCH] [Notifications] Apply initial properties passed from `hints` map This allows the job to show up atomically. Otherwise the popup will briefly show up empty until the first `update` call arrives. --- libnotificationmanager/jobsmodel_p.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libnotificationmanager/jobsmodel_p.cpp b/libnotificationmanager/jobsmodel_p.cpp index d3fed155e..21f900fb3 100644 --- a/libnotificationmanager/jobsmodel_p.cpp +++ b/libnotificationmanager/jobsmodel_p.cpp @@ -270,7 +270,7 @@ QDBusObjectPath JobsModelPrivate::requestView(const QString &appName, const QStr QDBusObjectPath JobsModelPrivate::requestView(const QString &desktopEntry, int capabilities, const QVariantMap &hints) { - qCDebug(NOTIFICATIONMANAGER) << "JobView requested by" << desktopEntry << "with hints" << hints; + qCDebug(NOTIFICATIONMANAGER) << "JobView requested by" << desktopEntry; if (!m_highestJobId) { ++m_highestJobId; @@ -317,6 +317,9 @@ QDBusObjectPath JobsModelPrivate::requestView(const QString &desktopEntry, int c job->setSuspendable(capabilities & KJob::Suspendable); job->setKillable(capabilities & KJob::Killable); + // Apply initial properties + job->d->update(hints); + connect(job, &Job::updatedChanged, this, [this, job] { scheduleUpdate(job, Notifications::UpdatedRole); });