From 141e1e58e39efb4ecaac01265bbaeb51c94e5878 Mon Sep 17 00:00:00 2001 From: Konrad Materka Date: Wed, 26 May 2021 01:06:33 +0200 Subject: [PATCH] [applet/systemtray] Optimize dataChanged on configuration change Do not call dataChanged in loop when range can be used. (cherry picked from commit 573388744490c43144e796f793878c946e125901) --- applets/systemtray/systemtraymodel.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/applets/systemtray/systemtraymodel.cpp b/applets/systemtray/systemtraymodel.cpp index 72760c4e8..941d2bb92 100644 --- a/applets/systemtray/systemtraymodel.cpp +++ b/applets/systemtray/systemtraymodel.cpp @@ -62,9 +62,7 @@ void BaseModel::onConfigurationChanged() m_shownItems = m_settings->shownItems(); m_hiddenItems = m_settings->hiddenItems(); - for (int i = 0; i < rowCount(); i++) { - Q_EMIT dataChanged(index(i, 0), index(i, 0), {static_cast(BaseModel::BaseRole::EffectiveStatus)}); - } + Q_EMIT dataChanged(index(0, 0), index(rowCount() - 1, 0), {static_cast(BaseModel::BaseRole::EffectiveStatus)}); } Plasma::Types::ItemStatus BaseModel::calculateEffectiveStatus(bool canRender, Plasma::Types::ItemStatus status, QString itemId) const