From 0cc0c32c2522b2ba42018a42c0b128efc346bc36 Mon Sep 17 00:00:00 2001 From: Aleix Pol Date: Fri, 1 Dec 2017 16:19:57 +0100 Subject: [PATCH] Readability No need to instantiate a process Properly warn when something didn't work --- ksmserver/startup.cpp | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/ksmserver/startup.cpp b/ksmserver/startup.cpp index a98ed4aea..17394f1b0 100644 --- a/ksmserver/startup.cpp +++ b/ksmserver/startup.cpp @@ -677,20 +677,15 @@ void KSMServer::slotAutoStart() return; } KService service(serviceName); - qCInfo(KSMSERVER) << "Starting autostart service " << serviceName; - auto p = new KProcess(this); auto arguments = KIO::DesktopExecParser(service, QList()).resultingArguments(); if (arguments.isEmpty()) { - qCInfo(KSMSERVER) << "failed to parse" << serviceName << "for autostart"; + qCWarning(KSMSERVER) << "failed to parse" << serviceName << "for autostart"; continue; } + qCInfo(KSMSERVER) << "Starting autostart service " << serviceName << arguments; auto program = arguments.takeFirst(); - p->setProgram(program, arguments); - p->start(); - connect(p, static_cast(&QProcess::finished), [p](int exitCode) { - qCInfo(KSMSERVER) << "autostart service" << p->program() << "finished with exit code " << exitCode; - p->deleteLater(); - }); + if (!QProcess::startDetached(program, arguments)) + qCWarning(KSMSERVER) << "could not start" << serviceName << ":" << program << arguments; } while (true); // Loop till we find a service that we can start. }