From 08b027f1124bd1cd841930405461e912e833535e Mon Sep 17 00:00:00 2001 From: Kai Uwe Broulik Date: Tue, 28 May 2019 16:08:29 +0200 Subject: [PATCH] [Notifications] Group applications with same display name but no desktop entry The specification says appName should be the display name of the application. An application may not send a desktop name at which point we have no other way of identifying it than the user-visible name it provides us. Differential Revision: https://phabricator.kde.org/D21460 --- libnotificationmanager/notificationgroupingproxymodel.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libnotificationmanager/notificationgroupingproxymodel.cpp b/libnotificationmanager/notificationgroupingproxymodel.cpp index 5ba4132c2..7960e18f2 100644 --- a/libnotificationmanager/notificationgroupingproxymodel.cpp +++ b/libnotificationmanager/notificationgroupingproxymodel.cpp @@ -44,7 +44,7 @@ bool NotificationGroupingProxyModel::appsMatch(const QModelIndex &a, const QMode const QString bDesktopEntry = b.data(Notifications::DesktopEntryRole).toString(); return !aName.isEmpty() && aName == bName - && !aDesktopEntry.isEmpty() && aDesktopEntry == bDesktopEntry; + && aDesktopEntry == bDesktopEntry; } bool NotificationGroupingProxyModel::isGroup(int row) const