wilderjds/okular - okular - gitea-jacopods

Author	SHA1	Message	Date
Albert Astals Cid	3304038d1d	ToggleActions: Obey "don't show text" for a particular action toolbar setting BUGS: 457322	4 years ago
David Hurka	4afd214701	ToggleActionMenu::createWidget(): Do not crash if parent is not a QToolBar There used to be a Q_ASSERT_X that was triggered when a widget was requested with something else than a QToolBar as parent widget. However, when the ToggleActionMenu is added to a QMenu, createWidget() is called with the QMenu as parent. This case was missed to be tested, but occurs when the toolbar is detached/moved by the user.	5 years ago
Alexander Lohnau	2f193a63de	Convert license headers to SPDX	5 years ago
Simone Gaiarin	87fa366c4a	Adapt annotation toolbar tests to new toggleable quick annotation	5 years ago
David Hurka	5a58d3bb8e	Simplify ToggleActionMenu * Remove the ImplicitDefaultAction intelligence, so ToggleActionMenu is not more than a KActionMenu with setDefaultAction(). * Instead, reset the default action when it gets removed from the menu(). This is done by filtering QActionEvent from menu(). * Add an autotest for ToggleActionMenu. This replaces prior efforts to fix problems in ToggleActionMenu in !245 and !254, following the discussion on the virtual meeting at 2021-02-26. `6b26a2b4b` and `1786e6c99` have already ported PageView and AnnotationActionHandler to the simplified interface.	5 years ago
David Hurka	19d5dd8ec7	New part/ directory for okularpart sources from /, ui/, conf/ Source files are no longer separated by UI and non-UI and similar, but only by their build target. * ui/ -> part/ * Move all source files from conf/ to part/ * Keep config skeleton definitions in conf/, needed for the mobile target too * Move editdrawingtooldialogtest.h from conf/autotests/ to autotests/ * ui/data/icons/ -> icons/ * Move /part.cpp, /part.rc and similar files to part/ * Adapt include paths in source files * Adapt CMakeLists.txt files (in / and in subdirectories) * Adapt /Messages.sh	5 years ago
Albert Astals Cid	19d98d6a74	Run clang-format find . \( -name ".cpp" -or -name ".h" -or -name ".c" -or -name ".cc" \) -exec clang-format -i {} \; If you reached this file doing a git blame, please see README.clang-format (added 2 commits in the future of this one)	6 years ago
Albert Astals Cid	a23709b097	CI: Enable clazy range-loop	6 years ago
David Hurka	c6d937ab0d	Replace ToolAction by ToggleActionMenu Summary: This replaces ToolAction by a near-drop-in replacement named ToggleActionMenu. The new annotation toolbar already uses this (D15580). Unlike ToolAction, ToggleActionMenu inherits from KActionMenu to be more flexible. * Menu can be set from outside, not hard coded. * Default action for toolbar button is controllable from outside. (Theoretically, the button could trigger //anything// now.) * KActionMenu instead of KSelectAction: - Pluggable in other menus, thus called “Menu”. - Doesn’t make the actions exclusive, so //any// actions can be added to the menu. * ImplicitDefaultAction mode can choose the default action of the toolbar buttons automatically, by looking for the first checked action in the menu. Toolbar buttons use the default action //of// this menu, not this menu itself as action. Because the default action is configurable now, D21622 and D21635 (where we tried to fine-tune ToolAction) become obsolete. Screenshot: Everything like before, here with mouse_selecttool added to Tools menu to show submenu capability. {F6884228} Test Plan: ToolAction replacement and ImplicitDefaultAction mode: * Open Okular and look at toolbar button -> has correct tool selected. * Open a document. * Look at toolbar button menu -> Correct menu entries (like before, with ToolAction). * Select some selection tools through shortcuts and toolbar button -> behaves correctly. Usage as submenu: * Add ToggleActionMenu ("mouse_selecttool") to menubar (..../kxmlgui5/okular/part.rc) -> Submenu looks correctly, has no checkbox attached and so on... Toolbar buttons: * Add diverse other actions to the menu -> still works as before. * Add actions when toolbar buttons are already created -> actions are added to existing buttons. * setDefaultAction() to some completely unrelated action. -> ToggleActionMenu does not get confused. Reviewers: simgunz Reviewed By: simgunz Subscribers: aacid, ngraham, simgunz, okular-devel Tags: #okular Differential Revision: https://phabricator.kde.org/D21971	6 years ago