okular

7371 Commits

9 Branches

332 Tags

50 MiB

Tag: Branch: Tree: f2e9633ea7

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Jake Linder	172d78c6b3	Add "Trim To Selection" feature Changes C1. Added submenu, moved "Trim margins" (TM mode) to it and added "Trim To Selection" (TS mode). C2. Activating "Trim To selection" enters a new mousemode, similar to RectSelect for defining a viewport. C3. Once a viewport has been defined, it serves as a viewport for all pages in the document. C4. Left/Right pages are not treated differently. Manual Testing T1. Switching between modes enforces at most one active. T2. Can deactivate a mode by selecting it again from the menu. T3. When draggin bbox selection, clicking outside page does not crash. T4. When in "Facing Pages" mode, mouse release must be over any page (or is ignored). T5. Normalized bbox coords are computed relative to page indicated by point of mouse release. T6. Behave as expected when switching between any pair of No Trim/Trim Margins/Trim To Selection. T7. TM mode persisted across app restarts (existing behavior). T8. TS mode forgotten across app restarts (as desired). T9. Exiting and reselectin "Trim To Selection" prompts for new bbox. T10. Choosing a small Trim bbox enforces minimium dimensions size (As percentag of total), as it does in TM mode, because of the "scale big and crop down" implementation, to avoid huge pixmaps. TS mode minimum set at 20% (vs. TM mode's 50%). REVIEW: 124716 BUGS: 351156	11 years ago
Fabio D'Urso	7db0647128	Removed zoom_fit_rect action from part.rc and part-viewermode.rc Because it's not used by Okular. Corresponding KPDF pageview code was removed in 2004 by commit `89cd5a2fa6`	14 years ago
Michel Ludwig	d29099b39c	Only activate a subset of the available features when the part is launched in viewer mode. In viewer mode the part will now use a different XML GUI file (part-viewermode.rc). Also, some actions won't be created, e.g. those used for exporting stuff, for launching presentation mode, or for selecting parts of the document. The captions of the configuration dialogs also contain the word 'viewer' then.	15 years ago

Jake Linder

172d78c6b3

Add "Trim To Selection" feature

Changes

C1. Added submenu, moved "Trim margins" (TM mode) to it and added  "Trim To Selection" (TS mode).
C2. Activating "Trim To selection" enters a new mousemode, similar to RectSelect for defining a viewport.
C3. Once a viewport has been defined, it serves as a viewport for all pages in the document.
C4. Left/Right pages are not treated differently.

Manual Testing

T1. Switching between modes enforces at most one active.
T2. Can deactivate a mode by selecting it again from the menu.
T3. When draggin bbox selection, clicking outside page does not crash.
T4. When in "Facing Pages" mode, mouse release must be over any page (or is ignored).
T5. Normalized bbox coords are computed relative to page indicated by point of mouse release.
T6. Behave as expected when switching between any pair of No Trim/Trim Margins/Trim To Selection.
T7. TM mode persisted across app restarts (existing behavior).
T8. TS mode forgotten across app restarts (as desired).
T9. Exiting and reselectin "Trim To Selection" prompts for new bbox.
T10. Choosing a small Trim bbox enforces minimium dimensions size (As percentag of total), as
it does in TM mode, because of the "scale big and crop down" implementation, to avoid huge pixmaps.
TS mode minimum set at 20% (vs. TM mode's 50%).

REVIEW: 124716
BUGS: 351156

11 years ago

Fabio D'Urso

7db0647128

Removed zoom_fit_rect action from part.rc and part-viewermode.rc

Because it's not used by Okular.
Corresponding KPDF pageview code was removed in 2004 by commit
89cd5a2fa6

14 years ago

Michel Ludwig

d29099b39c

Only activate a subset of the available features when the part is launched in viewer mode.

In viewer mode the part will now use a different XML GUI file (part-viewermode.rc).
Also, some actions won't be created, e.g. those used for exporting stuff, for
launching presentation mode, or for selecting parts of the document. The captions
of the configuration dialogs also contain the word 'viewer' then.

15 years ago

3 Commits (f2e9633ea7603df965eb7fdddf875fa8e950fb4d)