Changes
C1. Added submenu, moved "Trim margins" (TM mode) to it and added "Trim To Selection" (TS mode).
C2. Activating "Trim To selection" enters a new mousemode, similar to RectSelect for defining a viewport.
C3. Once a viewport has been defined, it serves as a viewport for all pages in the document.
C4. Left/Right pages are not treated differently.
Manual Testing
T1. Switching between modes enforces at most one active.
T2. Can deactivate a mode by selecting it again from the menu.
T3. When draggin bbox selection, clicking outside page does not crash.
T4. When in "Facing Pages" mode, mouse release must be over any page (or is ignored).
T5. Normalized bbox coords are computed relative to page indicated by point of mouse release.
T6. Behave as expected when switching between any pair of No Trim/Trim Margins/Trim To Selection.
T7. TM mode persisted across app restarts (existing behavior).
T8. TS mode forgotten across app restarts (as desired).
T9. Exiting and reselectin "Trim To Selection" prompts for new bbox.
T10. Choosing a small Trim bbox enforces minimium dimensions size (As percentag of total), as
it does in TM mode, because of the "scale big and crop down" implementation, to avoid huge pixmaps.
TS mode minimum set at 20% (vs. TM mode's 50%).
REVIEW: 124716
BUGS: 351156
Removed name attribute from default tools (ie those from tools.xml), so
that they now get default names, which automatically translated if the
application language is switched.
With this patch, tools.xml no longer contains strings to be translated.
NOTE: Messages.sh was not tested
Two purposes:
- Have tooltips available even for user-created annotations (not just
the predefined ones)
- Avoid i18n strings in settings (NOTE: the "name" attribute will be
removed in next patch)
Some tooltips were created over new (eg for new tools), some were
rewritten to actually give instructions instead of repeating the name of
the tool, some were rewritten to avoid references to colors (because
colors are no longer fixed)
Translate strings when retrieving the default annotation tool list, so
that we can assume that strings in the AnnotationTools setting are
translated.
Note: In future patches, I'll remove i18n strings from the default tool
list at all
Instead of using a system-wide tools.xml file containing a list of
<tool>...</tool> elements, store each tool element as string in a
stringlist configuration option.
Note that the global tools.xml file is still needed to read the
default values.
Will make it easier to make separate apps based on the core in the future
Note this will most probably break your settings if you are not running a very up to date kdelibs (4.9 or 4.10)
so be careful on updating
REVIEW: 104947
The default mouse mode on Okular startup is panning. I almost always
want text selection. Somebody else might prefer rectangular selection or
zooming. This patch stores the last active mouse mode in the config and
switches to it on startup.
REVIEW:104147
This is done through a string "ConfigFileName=<file name>" which can be given to
the constructor in its argument list.
Note that the file ui/fileinterpreterpreview.cpp currently still contains a
reference to "okularrc", which we leave for now (as it just stores the size
of a dialog in that config file).
Change the ViewMode to be an Enum instead of an ugly int and fix the ugly code accordingly. This will break your ViewMode config, i'm sorry for that
Move the setting for centered pages to the view mode as people seems to be having a lot of difficulties of finding it in the old location
svn path=/trunk/KDE/kdegraphics/okular/; revision=1072353
and Reviews side panels to okularpartrc.
If these options are turned on they are now saved as:
[Contents]
ContentsSearchCaseSensitive=true
ContentsSearchRegularExpression=true
and
[Reviews]
ReviewsSearchCaseSensitive=true
ReviewsSearchRegularExpression=true
respectively.
svn path=/trunk/KDE/kdegraphics/okular/; revision=1051497
Based on a patch by Alejandro Exojo, thanks!
$ kwriteconfig --file okularpartrc --group General --key DisplayDocumentTitle --type bool false
BUG: 158401
svn path=/trunk/KDE/kdegraphics/okular/; revision=890576
Separated normal & cropped geometries in page items;
made the page painter able to draw based on a crop section;
add a config + menu option for turning the white borders removal.
Based on a patch by the Mr. anonymous kde2eran@tromer.org, thanks.
BUG: 161599
svn path=/trunk/KDE/kdegraphics/okular/; revision=809496
Default is "Default Screen", with the options for showing it to any available screen.
Also, dynamically resize when the screen used for the presentation mode changes size during a presentation.
Many thanks to 'zbsz' for his testing!
CCMAIL: zbigniewo@gmail.com
GUI:
svn path=/trunk/KDE/kdegraphics/okular/; revision=794501
Jake Linder
Tobias Koenig
Saheb Preet Singh
Jeremy Whiting
Montel Laurent
Vishesh Handa
Michal Humpula
Albert Astals Cid
Thomas Fischer
Fabio D'Urso
Bogdan Cristea
Sandro Mani
Mailson Menezes
Parker Coates
Albert Astals Cid
Michel Ludwig
Michal Svec
Martin Ueding
Elvis Stansvik
Pino Toscano