Summary:
Files saved with QSaveFile don't get dirty. They are deleted and replaced.
Thus, inotify and KDirWatch don't emit a "dirty" signal (which is the correct behaviour).
Listening for the "created" signal of KDirWatch allows us to get notified on replaced files.
BUG: 384185
Test Plan:
Opened a markdown document in Okular.
Edited and saved the document with Kate.
The file is reloaded in Okular as expected.
Reviewers: aacid
Reviewed By: aacid
Subscribers: sander, rkflx, #okular
Tags: #okular
Differential Revision: https://phabricator.kde.org/D7671
Unregister the part dbus object when it gets destroyed
Also fixes a crash if you try to inspect okular with qdbusviewer after having closed the a part/tab
BUGS: 384142
QMenu title/section are optional to draw from the style side but we have crucial information in them
so reuse old KMenu code to create a fake action that behaves as title
I'll see if KF5 wants to accept this as contribution later
BUGS: 374079
3 benefits:
* We can set the shortcut in the edit shortcuts dialog as before
* Shortcuts can be activated without showing the topbar as before
* Drawing in the toppbar is exactly as the other actions
The old auto_ptr was used for simple RAII. None of the auto_ptr flaws
were apparent in that context, but given that that class is actively
deprecated and that compilers warn about its use, it's better to switch
to its drop-in replacement.
My reason for not using QScopedPointer is that the C++11 version works
well enough, Okular is being built in C++11 mode anyway, unique_ptr
works on the KF5-minimal-mandated-compilers according to their docs, and
therefore there's no point in using something with a different API
(QScopedPointer) just because its name begins with a Q.
REVIEW: 124027
Wow, I have no idea how this happened. I wrote an big test case and spent a lot of time playing with tabs. Stephan Binner even told me about this a month ago, but I didn't quite understand the problem...
Broken embed mode detection means that the tabbed interface is disabled. It actually made it into release... ugh
REVIEW: 123680
Julian Wolff
Kevin Funk
Albert Astals Cid
Gilbert Assaf
Oliver Sander
Luigi Toscano
Yuri Chornoivan
Albert Vaca
Aleix Pol
Martin T. H. Sandsmark
Olivier CHURLAUD
Alex Richardson
Montel Laurent
Tobias Koenig
Saheb Preet Singh
Jan Kundrát
Jonathan Doman
Jeremy Whiting
Lukáš Tinkl