Okular's sidebar vertical view chooser toolbar suffers from a few issues:
* It's a nonstandard UI not used for category choosers in other pieces of KDE software,
and not used in other FOSS document readers
* What is shown and what is hidden is simultaneously too configurable while still not
offering the desirable UI common to other programs (i.e. no visible category chooser,
but a sidebar capable of displaying thumbnails, table of contents, search results, etc.)
* With labels on it takes up quite a bit of horizontal space, while with labels off, the
categories are less than clear
* UX is kind of clunky with nonstandard behaviors (e.g. clicking on the current category
to hide that category's view while keeping the view chooser visible, showing mostly
disabled items)
* It's made with custom painting code, which reduces maintainability and introduces bugs
(e.g. https://bugs.kde.org/show_bug.cgi?id=408190)
This patch removes the vertical category chooser entirely and replaces it with a tabbed
view on the top of the sidebar itself. The tabs are icons-only and have large icons. A
button is added on the left side of the default toolbar to quickly hide or show the
sidebar. In order to make room for the new button, the Previous and Next buttons on the
toolbar are removed, as previous/next buttons are already present on the Page Bar on the
bottom of the window so there's no need to duplicate this functionality. This improves
the UX, fixes a variety of bugs, and deletes a lot of custom code of dubious long-term
maintainability.
BUG: 213508
BUG: 334441
BUG: 344599
BUG: 408190
CCBUG: 335189
FIXED-IN: 1.11.0
CHANGELOG: The sidebar can now be easily shown or hidden with a toolbar button, and the category chooser no longer takes up so much space
Summary:
Adds two buttons on the bottom right to expand and collapse all elements in annotations
BUG: 377024
T8553
With latest breeze-icons:
{F6687517}
Without it:
{F6687519}
{F6687518}
Reviewers: #okular, #vdg, ngraham
Subscribers: ndavis, aacid, ngraham, okular-devel
Tags: #okular
Differential Revision: https://phabricator.kde.org/D18358
Summary:
Some people need them
BUG: 403445
Test Plan: Can be compiled, installed, can be spotted in the GUI.
Reviewers: #okular, ngraham
Reviewed By: ngraham
Subscribers: ngraham, #vdg, GB_2, okular-devel
Tags: #okular
Differential Revision: https://phabricator.kde.org/D18429
Just use the pointer as id :-)
This is BIC and SIC, increase the soversion now to makes sure we don't forget in the future
Patch based in an earlier patch by Bogdan Cristea <cristeab@gmail.com>
REVIEW: 109115
Since the review pane has different requirements than the page view, this
change introduces a mode parameter to the AnnotationPopup ctor.
REVIEW: 106045
* We do not keep them around any more time than needed (they are cheap to create)
* AnnotWindow::slotsaveWindowText calls m_document->modifyPageAnnotation so
edition of inline notes happens immediately
and Reviews side panels to okularpartrc.
If these options are turned on they are now saved as:
[Contents]
ContentsSearchCaseSensitive=true
ContentsSearchRegularExpression=true
and
[Reviews]
ReviewsSearchCaseSensitive=true
ReviewsSearchRegularExpression=true
respectively.
svn path=/trunk/KDE/kdegraphics/okular/; revision=1051497
- keep ownership of the "export as" menu, and check before manipulating its child widgets: avoid crashes in case the part widget is destroyed before the pa
rt is
both the problems discovered and debugged with the precious help of Armin Berres, thanks!
CCMAIL: trigger@space-based.de
svn path=/trunk/KDE/kdegraphics/okular/; revision=863716
Nate Graham
Albert Astals Cid
Ahmad Samir
Laurent Montel
Joao Netto
Yuri Chornoivan
Kevin Funk
Albert Vaca
Aleix Pol
Vishesh Handa
Frederik Gladhorn
Tobias Koenig
Albert Astals Cid
Elvis Stansvik
Pino Toscano
Eike Hein
Jakob Petsovits