Better enforce them now, so that the work to port doesn't increase over
time
Not a super fan of this for regular applications, but oh well the ship
has sailed
epub_open wants an utf8 in Windows
It probably also wants utf8 in Linux, but the qPrintable already gives
us an utf8 in most of the normal Linux locales, so don't touch that
BUGS: 448274
find . \( -name "*.cpp" -or -name "*.h" -or -name "*.c" -or -name "*.cc" \) -exec clang-format -i {} \;
If you reached this file doing a git blame, please see README.clang-format (added 2 commits in the future of this one)
CCBUG: 391625
Test Plan: I tested the file mentioned in the bug report. Pictures look less blurry
Reviewers: #okular
Subscribers: ngraham, aacid, okular-devel
Tags: #okular
Differential Revision: https://phabricator.kde.org/D13766
Cases that are fixed by this change are:
- Filenames that didn't start with "/" weren't concatenated properly to
the base path.
- Non-normalized paths (eg: having "../") couldn't be resolved by libepub.
QUrl::resolved() normalizes the paths after concatenating them.
- Paths with special characters were escaped because of using
QUrl::toString() instead of QUrl::path(), making them not work.
Reviewed by Albert Astals.
Diggory i think there was a misunderstanding in our discussion
The patch is unfinished (not goot to commit with a TODO)
and needs to be improved (need to find a way to not break ABI, QSize param should be const &) please
open a reviewrequest and we can discuss/finalize it there.
CCMAIL: diggory.hardy@unibas.ch
this way we can load resources of 0 bytes (not much useful per-se, but at least we know they are actually existing in the epub archive)
svn path=/trunk/KDE/kdegraphics/okular/; revision=1182899
When iterating through the document HTML files, set in the epub document the URL of the current file being loaded,
so it is possible to resolve the locations of resources based on the base URL of the current file.
This makes it possible to load resources like "foo.css", "somedir/foo.css", "../somedir/foo.css" and so on.
BUG: 198764
FIXED-IN: 4.6
svn path=/trunk/KDE/kdegraphics/okular/; revision=1182629
Albert Astals Cid
Nicolas Fella
Volker Krause
Alexander Lohnau
Carl Schwan
Gilbert Assaf
Martin T. H. Sandsmark
Albert Vaca
Montel Laurent
Lukáš Tinkl
Frederik Gladhorn
Diggory Hardy
Vishesh Handa
Jaydeep Solanki
Pino Toscano
Pascal Létourneau