Enrico i tried to see if that was needed for some corner case but could not find it, please review if this change breaks something else and tell me if it does not and i'll backport to the stable branch
BUGS: 104900
svn path=/trunk/kdegraphics/kpdf/; revision=409086
Do not assume that there can be only one objectrect in a given point, remove const ObjectRect * KPDFPage::getObjectRect( double x, double y ) const and add const ObjectRect * KPDFPage::hasObject( ObjectRect::ObjectType type, double x, double y ) const instead
BUGS:101648
svn path=/trunk/kdegraphics/kpdf/; revision=398214
A good document to test is cups/idd.pdf that has links 1, 1.1, 1.2 and 1.3 all to the same page but with different viewports
Seems to work but a review of the code is always good :-D
svn path=/trunk/kdegraphics/kpdf/; revision=396528
To fix it what we do is close the document, show a message telling that the document is beign reloaded and then open the document again when it's ready, that presents a big problem to a backport, because without the text it is really not understood that something is happening.
Enrico any idea to do this in a better way so we can backport it?
BUGS: 101192
svn path=/trunk/kdegraphics/kpdf/; revision=396219
that Albert fixed a while ago). Always ensure that pixmaps are requested
if a relayout has been performed, even if the viewport is not moved but
contents changed.
Removed a warning.
svn path=/trunk/kdegraphics/kpdf/; revision=390694
User Interface: added a toolbox for selecting an annotation tool without
polluting the toolbar (pageviewtoolbox animated widget). Icons of that
toolbar are gimped version of ones in nuvola icontheme.
Core: added annotation class. this will support all features (except for
silly ones (really there are some!)) from pdf 1.6 specs but abstracted
in the kdpf way. (api changes in progress...)
About annotations: only some incomplete interfaces are in plasefor now.
Every type of pdf annotations has tens of parameters. I think we'll render
correctly everything but provide only simple and useful tools for making
annotations over the pages, otherwise a 'Qt designer like' property view
will be required to do fine adjustment over the crappy thousands of
settings. (and we're aiming at a quick and simple viewer with lots of
coolness, not chaos).
Have fun!
svn path=/trunk/kdegraphics/kpdf/; revision=388699
- Keep the original url on the document so we can open relative file names
- Add Enrico and my copyright
svn path=/trunk/kdegraphics/kpdf/; revision=386244
Removed old code, reworked bad code.
I have no more reported crashes now.
No plans for additions or code changes till 3.4 release.
Thank you all kpdf users, Have Fun!
svn path=/trunk/kdegraphics/kpdf/; revision=385897
without including any 3.4 header (like kspeech.h) to keep compatibility
with 3.3 and older releases (reported to work on these).
Cleanups in PageView's mouse handling. Supports selections of different
colors now.
svn path=/trunk/kdegraphics/kpdf/; revision=383651
Part). Implemented 'history (xpdf's LinkAction) links'. History depth is
100 steps by default (this is enough for sure, clicking 100 times on a
button is not an easy task :-).
Minor issues (removed half TODOs in code, all FIXMEs are already removed):
Invoke mailer on 'mailto:' links inst instead of konqueror.
Actions cleanup: disable actions like 'print', 'preview', 'save to..', etc
when there isn't an active document. Added history actions to the toolbar
in place of the 'prev_page' and 'next_page' ones. Fixed open+open_recent
action tooltip and behavior.
Move definition and implementation of PagePainter class to ui/pagepainter
from core/page.
Valgrinded and leakchecked (2 memory leaks spotted and fixed (missing
contents deletion in KPDFGeneratorThread and missing deletion of
PixmapRequests on cancel in Document::requestPixmaps())).
svn path=/trunk/kdegraphics/kpdf/; revision=382960
of wasted PixmapRequests (regressions introduced by DocumentViewport).
Optimizations.
Document: Fixed oscillations in memory deallocator. Merged 'cleanupMemory'
and 'freeMemory' -> 'cleanupPixmapMemory'.
Delayed initialization of QTimers.
GeneratorPDF: Added a comment on threading and asyncronous pixmap loading.
TODO: updated adding items by Mikolaj Machowski and Grzegorz Ja?kiewicz
svn path=/trunk/kdegraphics/kpdf/; revision=380913
Fix cache deallocator. Hard avoids swapping memory or filling it up to the
limit (allocated pages are referenced in an internal add/remove FIFO).
Merged open and open_recent buttons as many users requested.
Using viewmag icon for find-as-you-type popup.
Disabled debug output. Updated todo with the roadmap to release.
- Need to audit the memory code and choose good default policies now.
svn path=/trunk/kdegraphics/kpdf/; revision=380494
Display contents faster, waste less memory. Added preloading to forward-
generate pages (if threading enabled and memory profile >= normal). Main
pages are always generated first, then thumbnails come, then preload ones,
etc.. Btw memory and cpu will be happier now.
(1 bug in memory and 1 in preloading still remains.. will be spotted soon)
For Developers:
Generator: dropped moc, api changes, better functions naming.
PDFGenerator and Document: moved requests queue to the Document.
The generator performs only a single request a time. A flag can be
queried to know if the generator is ready for starting another pixmap
generation or not (in case it's generating a pixmap in background).
PixmapRequest: added priority and backgound (async) attributes.
Document: queuing requests by priority in requestPixmaps.
Observer: added defines for priorities used in doc->requestpixmaps.
PageView: delayed find-ahead timer creation (not created if not needed).
Added preload PixmapRequests to the pixmap requests list.
ThumbnailsList: adapted to pixmapRequest changes and changed naming for
delayed thumbanils request.
svn path=/trunk/kdegraphics/kpdf/; revision=379820
Add some accelerators
Plug the actions that change the mouse behaviour into a menu as everything should be menu accesible
Put the F9 in the KACtion creator
svn path=/trunk/kdegraphics/kpdf/; revision=377533
bodies. Optimized fit width and a saved a couple of pixmap requests. Busy
cursor on load and searches.
svn path=/trunk/kdegraphics/kpdf/; revision=377152
Albert Astals Cid
Jakub Stachowski
Enrico Ros
Andrew Coles
Lukáš Tinkl