Instead of listening on KConfigDialog's signals, this patch makes parts
listen on Okular::Settings::self()'s configChanged() signal.
Unlike KConfigDialogs, Okular::Settings::self() is unique and never
changes during the process lifetime, and therefore:
- A part can connect during initialization and receive notifications,
without depeding on KConfigDialog objects (which might be instanced
or deleted by a different part).
- The connection now survives deletion of the KConfigDialog.
Just use the pointer as id :-)
This is BIC and SIC, increase the soversion now to makes sure we don't forget in the future
Patch based in an earlier patch by Bogdan Cristea <cristeab@gmail.com>
REVIEW: 109115
SlotDoFileDirty tries to reload the file at regular intervals.
This patch fixes it so that it can actually reopen the file even if
it is not ready at the first timer shot.
BUG: 310531
This patch turns Okular into a ReadWritePart. Annotation editing is always
disabled if we're loaded as ReadOnlyPart, no matter the document type.
REVIEW: 105020
Ok, this is not really the review Jonathan did, i did rewrite the code partially because i did not really
want to have a new observer, but the code is heavily inspired in his patch.
Also the page number selector is not in the toolbar as the review had, it'd be silly to have it in both places
by default, so if you want to have it you have to go, edit the toolbar and add the "Page Number" action to it.
REVIEW: 103427
BUGS: 279128
FIXED-IN: 4.9.0
The method 'showSourceLocation' has been extended with a new parameter which
controls whether the given source location is shown graphically. A new method
'clearLastShownSourceLocation' has been added; and a corresponding implementation
is provided.
In viewer mode the part will now use a different XML GUI file (part-viewermode.rc).
Also, some actions won't be created, e.g. those used for exporting stuff, for
launching presentation mode, or for selecting parts of the document. The captions
of the configuration dialogs also contain the word 'viewer' then.
This is done through a string "ConfigFileName=<file name>" which can be given to
the constructor in its argument list.
Note that the file ui/fileinterpreterpreview.cpp currently still contains a
reference to "okularrc", which we leave for now (as it just stores the size
of a dialog in that config file).
apply it to the print preview mode (effectively replacing the "dummy mode"), and to the "native shell" case
svn path=/trunk/KDE/kdegraphics/okular/; revision=942873
- loading: slightly edited the loading function to call the right open function of Document in case the file is a document archive (choosen normally in the "open" dialog)
- saving: added an entry in the "export to" formats (and shuffled some code for being more flexible)
probably not much ideal for an usability POV, but we can work on it.
svn path=/trunk/KDE/kdegraphics/okular/; revision=884852
- keep ownership of the "export as" menu, and check before manipulating its child widgets: avoid crashes in case the part widget is destroyed before the pa
rt is
both the problems discovered and debugged with the precious help of Armin Berres, thanks!
CCMAIL: trigger@space-based.de
svn path=/trunk/KDE/kdegraphics/okular/; revision=863716
in case for some reason (read: Firefox blindly removing temporary files) it gets "deleted".
Of course, this works (and thus it is activated) only on UNIX systems (as the file is not deleted for real until there are open handles on it).
BUG: 163363
(If not wanted, this behavior can be disabled by export'ing OKULAR_NO_KEEP_FILE_OPEN to 1.)
Also, in case the local file gets deleted but the real document is remote, use its (remote) URL for the copy.
svn path=/trunk/KDE/kdegraphics/okular/; revision=818136
The current implementation is very very very simple and minimal, and misses a bit of stuff (eg the queue'ing for messages, errors, etc), but for now seems working.
Many thanks to Maksim for his precious help with the extension working :)
svn path=/trunk/KDE/kdegraphics/okular/; revision=792030
Fabio D'Urso
Tomáš Poledný
Albert Astals Cid
Jaydeep Solanki
Mailson Menezes
Albert Astals Cid
Jonathan Marten
Elvis Stansvik
Michel Ludwig
Jiri Baum
Christopher Reichert
Pino Toscano