Since 6d6a3bfce5, files are opened in a
new Shell instance and the current one is unaffected, therefore changes
to the current file do not get lost any more.
Call m_part->closeUrl with promptToSave=false in the Shell dtor, so that
the save changes prompt is not shown again (it's already shown because
of Shell::queryClose)
Call m_part->closeUrl with promptToSave=false in the Shell dtor, so that
the save changes prompt is not shown again (it's already shown because
of Shell::queryClose)
Stop being too smart for own our good, try to merge open and openRecent actions in just one action
confuses the hell out of people, so let's KISS and just make open recent be open recent
BUGS: 302358
BUGS: 251335
FIXED-IN: 4.10.0
Otherwise we end up in a busy loop on part deletion if there are pending requests
Should not happen but if this fixes it don't see the need to lose time investigating
why given the number of todo things
Otherwise we end up in a busy loop on part deletion if there are pending requests
Should not happen but if this fixes it don't see the need to lose time investigating
why given the number of todo things
The machinery in KParts/QObject is already doing it and this way we don't get the
KXMLGUIClient::~KXMLGUIClient: 0x15637528 deleted without having been removed from the factory first. This will leak standalone popupmenus and could lead to crashes.
warning
I'm not sure if calling this a kdelibs bug yet or not though :D
BUGS: 261538
FIXED-IN: 4.9.1
The machinery in KParts/QObject is already doing it and this way we don't get the
KXMLGUIClient::~KXMLGUIClient: 0x15637528 deleted without having been removed from the factory first. This will leak standalone popupmenus and could lead to crashes.
warning
I'm not sure if calling this a kdelibs bug yet or not though :D
BUGS: 261538
FIXED-IN: 4.9.1
This patch turns Okular into a ReadWritePart. Annotation editing is always
disabled if we're loaded as ReadOnlyPart, no matter the document type.
REVIEW: 105020
rembemer the values of m_menuBarWasShown and m_toolBarWasShown
Patch based in a patch by Victor Blazquez
svn path=/trunk/KDE/kdegraphics/okular/; revision=1185957
make the function able to be reused in unit tests (ie adding a function hook for the filename existance check)
svn path=/trunk/KDE/kdegraphics/okular/; revision=1032962
- on command line, properly read the URL ref ('#foobar' at the end), avoiding a KCmdLineArgs behaviour which encodes it as part of the file name
- pass what was specified as ref or the page (as specified with -p/--page) to the kpart
- make the okularpart take out the ref from the URL it opens and then:
a) if it is a number, assume it is the destination page number
b) otherwise, use that string as named destination
CCMAIL: okular-devel@kde.org
svn path=/trunk/KDE/kdegraphics/okular/; revision=969227
This currently does not seem to work as it should, because the max size is really contrained to 2/3 of the screen size, as per Qt behaviour (or bug?)
Anyway, even 2/3 is better than before.
svn path=/trunk/KDE/kdegraphics/okular/; revision=912463
Rafael:
new order contradicts with API docs:
http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/classKXmlGuiWindow.html#e5ac6ec22a61a4d854600c0f5a41e8d4
if this is an exception (i.e. both docs and okular's calling order are fine),
then please add appropriate comment to the code.
also, I ask you to look into another problem: okular doesn't restore maximization on start.
CCMAIL:pino@kde.org
CCMAIL:ereslibre@kde.org
svn path=/trunk/KDE/kdegraphics/okular/; revision=868604
-don't call setAutoSaveSettings() as it is called implicitly by kxmlgui system
the problem i was shooting at still doesn't solved though: maximization ain't restored properly.
it is saved correctly, but it seems that in restoreWindowSize calling KWindowSystem::setState doesn't do the job.
obviously, this must have smth to do with kparts framework.
CCMAIL:pino@kde.org
svn path=/trunk/KDE/kdegraphics/okular/; revision=868586
Albert Astals Cid
Tomáš Poledný
Ivan Čukić
Yuri Chornoivan
Jaydeep Solanki
Fabio D'Urso
Aaron Seigo
Montel Laurent
Mohammad Mahfuzur Rahman Mamun
David Palacio
Aurélien Gâteau
Albert Astals Cid
Pino Toscano
Christian Ehrlicher
Nick Shaforostoff