Say "Play Sound" instead of "Follow this link"
Only offer to stop sound when there's one playing
Inspired by https://git.reviewboard.kde.org/r/120683 by Nidhi Jain
On 45dc1990 i made the wrong assumption that if you were in
slotRequestVisiblePixmaps with the mid mouse button pressed
it meant that you were mid mouse button zooming, but this is not
true if you mid mouse click on the scrollbar.
So the solution to ignore pixmap request on mid mouse button zooming
is actually use blockPixmapsRequest
BUGS: 341583
FIXED-IN: 14.12.1
Fixes the case in which the page has duration, and Okular::SettingsCore::slidesAdvanceTime is smaller than the page duration but autoAdvance is disabled
BUGS: 340035
Somehow i ended up commiting a partial patch and not what was in reviewboard, this amends the previous commit to be what i really wanted to commit
Sorry for the mess :/
This way dvi and any other potential user gets it for free
The diff is huge, but the synctex files are just moves.
And the code in core/ is also mostly just a move from the generator_pdf.cpp code
Acked by Luigi
REVIEW: 120311
We need
disconnect(textEdit, SIGNAL(cursorPositionChanged()), this,SLOT(slotsaveWindowText()));
and it's counterpart, otherwise when inserting the image, the cursor pos changes, slotsaveWindowText is called, the content is passed by a toPlainText and set again and kaboom the content is lost
Also a few extra const
BUGS: 335476
FIXED-IN: 4.14.2
No other parts which renders PostScript are available at the moment,
and parts which handles them are return "unexpected" resultS (e.g.
katepart: PostScript source code).
Reviewed by: Albert Astal Cid
BUG: 284428
FIXED-IN: 4.13.2
Those two categories are usually longer messages and more
important, so more fit for a (new) KMessageWidget; simple
notice signals still go to PageViewMessage into PageView.
A more general review of all the messages should be probably
performed in order to assign proper categories to them.
Reviewed by: Albert Astal Cid
No need for double digit precision in the UI
ZoomIn/ZoomOut moves you through the well known steps + fit page, fit width; if you need any other you can always write it manually or use MMB zoom
BUGS: 323434
BUGS: 323435
FIXED-IN: 4.14.0
REVIEW: 112370
Opened a file with all pages with same size and behaves exactly like Okular does
Opened a file with pages with different sizes and behaves like Okular does until it stops fiting. In that moment the page bar is not centered anymore to let the text still fit and once the text doesn't fit anymore it starts getting ellided.
Reviewed by Luigi
BUGS: 333349
FIXED-IN: 4.13.1
In an ideal world I would have commented this in reviewboard and Michal would
have fixed it, but Feature Freeze is almost here so I decided just to fix it myself
In an ideal world I would have commented this in reviewboard and Saheb would
have fixed it, but Feature Freeze is almost here so I decided just to fix it myself
It's straighforward implementation. Every single place, where there were call for (or with) TilesManager, now has a DocumentObserver as companion. The m_tiledManager reference in PagePrivate was changed to QMap<DocumentObserver, TilesManager>.
REVIEW: 113986
This has the exact same behaviour of clicking the toolbox Settigs > Configure Okular > Accessibility > Change colors and then clicking Ok, therefore changing the saved configs.
BUGS: 173264
FIXED-IN: 4.12.0
Also simplified code a bit by removing unnecessary calls to toLower in TextPagePrivate::findTextInternalForward and TextPagePrivate::findTextInternalBackward I also fixed a small bug: the letter capital I with dot above (U+0130) did not match itself in case-insensitive mode on Qt 4.8.4 (U+0130 still does not match lowercase i (U+0069), which can be considered another bug, that I didn't fix (although this behavior conforms to the Unicode case folding rules)).
(I did not implement the Knuth-Morris-Pratt algorithm that I promised in a comment of Bug 323263 because on second thought I find that the win, if any, would probably be negligible except for some very special documents and special query strings.)
BUGS: 323262
BUGS: 323263
REVIEW: 112135
Albert Astals Cid
Jonathan Doman
Nidhi Jain
Yuri Chornoivan
Jon Mease
Luigi Toscano
Tingnan Zhang
Montel Laurent
Michal Humpula
Saheb Preet Singh
Alexander Potashev
Ciro Santilli
Jaydeep Solanki
Jaan Vajakas
Fabio D'Urso
Thomas Fischer