So that the hoverIcon is not shown above the newly created annotation.
This was especially visible if the creation of the annotation triggers a
message box warning, because one could see both the annotation and the
hover icon as long as the warning wasn't closed.
Note that if a low-res 16x16 version is available, it is shown instead
of the 64x64 version actually used by PagePainter.
e.g. try with the default stamp "Okular"
- Changed property dialog title from "Highlight" to "Text Markup",
because it's used for Underline, Squiggle and Strike out too.
- Renamed Squiggly (adjective) to Squiggle (noun)
- Show the precise type of HighlightAnnotation in the review panel and
on right-click on a HighlightAnnotation
Removed name attribute from default tools (ie those from tools.xml), so
that they now get default names, which automatically translated if the
application language is switched.
With this patch, tools.xml no longer contains strings to be translated.
NOTE: Messages.sh was not tested
Two purposes:
- Have tooltips available even for user-created annotations (not just
the predefined ones)
- Avoid i18n strings in settings (NOTE: the "name" attribute will be
removed in next patch)
Some tooltips were created over new (eg for new tools), some were
rewritten to actually give instructions instead of repeating the name of
the tool, some were rewritten to avoid references to colors (because
colors are no longer fixed)
Since the size of pixmap is determined by the value of size variable,
we can directly read that variable instead of querying the pixmap.
Also note that "pixmap" comes from "hoverIcon", not from "icon", and
that piece of code wants to know the size of the latter. In case of
stamp annotations, however, they happen to be the same.
Note that previously the width attrubute was ignored by the PolyLine
engine and it always set width=1, that's why I had to change the default
value in tools.xml.
So that they are the same color as the annotations they create.
This patch also adds some new icons.
Affected annotation tools:
- Ellipse
- Polygon
- Rectangle (NEW)
- Squiggly (NEW)
- Line
- Strikeout (NEW)
- Underline
I'll edit the remaining icons in next patches.
Translate strings when retrieving the default annotation tool list, so
that we can assume that strings in the AnnotationTools setting are
translated.
Note: In future patches, I'll remove i18n strings from the default tool
list at all
Instead of using a system-wide tools.xml file containing a list of
<tool>...</tool> elements, store each tool element as string in a
stringlist configuration option.
Note that the global tools.xml file is still needed to read the
default values.
It was "Note" before d2fa4c9, but it was changed to "Comment" for
compatibility reasons. Setting it to "Note", this time in UI code,
doesn't break d2fa4c9 and restores the default icon users are used to.
* We do not keep them around any more time than needed (they are cheap to create)
* AnnotWindow::slotsaveWindowText calls m_document->modifyPageAnnotation so
edition of inline notes happens immediately
Patch by Raffaele Mancuso cleaned up by me
This will be in KDE 4.7.0
This fixes the original report of bug 161020 so i'm closing it
If there were any other different wish report in that bug, do the proper thing an open a new one
BUGS: 161020
svn path=/trunk/KDE/kdegraphics/okular/; revision=1218185
also, no need to iterate again, as the input dialog will not accept an empty (not totally blank) value
furthermore, abort annotator creation if the user aborts the input dialog
BUG: 236865
svn path=/trunk/KDE/kdegraphics/okular/; revision=1160649
- added few utility functions to compensate the miss of a "central scrolled widget", as now we just fully handle (events & painting) the viewport of the scroll area
- manually scroll the overlay widgets (form widgets and video widgets) when the "area" is scrolled
All the page view functionalities should be working as usual, hopefully I should have ported everything (in case it will be fixed later).
Given that now the size page view is no more constrained by the maximum size of a QWidget (which is two orders of magnitude less than the size of an int), we can handle documents with really many pages (10k+) with hopefully no issues.
BUG: 191859
As a side effect of the QScrollArea -> QAbstractScrollArea porting, it seems that there are no more drawing glitches when in right-to-left mode.
BUG: 192636
svn path=/trunk/KDE/kdegraphics/okular/; revision=989285
Separated normal & cropped geometries in page items;
made the page painter able to draw based on a crop section;
add a config + menu option for turning the white borders removal.
Based on a patch by the Mr. anonymous kde2eran@tromer.org, thanks.
BUG: 161599
svn path=/trunk/KDE/kdegraphics/okular/; revision=809496
Fabio D'Urso
Jon Mease
Peter Grasch
Albert Astals Cid
Sandro Mani
Albert Astals Cid
Montel Laurent
Burkhard Lück
Pino Toscano