If the argument mimetype and filepath mimetype disagree, first try to use the filepath mimetype and if that fails use the argument one. On top of that if text/plain is the first, first try with content mimetype since the text backend never fails to open a file
I can now open https://bugs.freedesktop.org/attachment.cgi?id=99508 (which is served as text/plain) and PS files with .txt extension (bug 325044)
REVIEW: 119737
BUGS: 325044
FIXED-IN: 4.14.0
The text generator is the only one compiled now.
This version links for me but then doesn't find its KPart on startup.
TTS has been completely disabled as well as some other things like the
about dialog.
If a "fast" sequence of signals is sent to the part, the hiding
animation could lead to a broken resize (as it the new message
is handled during the resize). Remove the animation for now.
Those two categories are usually longer messages and more
important, so more fit for a (new) KMessageWidget; simple
notice signals still go to PageViewMessage into PageView.
A more general review of all the messages should be probably
performed in order to assign proper categories to them.
Reviewed by: Albert Astal Cid
Opened a file with all pages with same size and behaves exactly like Okular does
Opened a file with pages with different sizes and behaves like Okular does until it stops fiting. In that moment the page bar is not centered anymore to let the text still fit and once the text doesn't fit anymore it starts getting ellided.
Reviewed by Luigi
BUGS: 333349
FIXED-IN: 4.13.1
In an ideal world I would have commented this in reviewboard and Saheb would
have fixed it, but Feature Freeze is almost here so I decided just to fix it myself
It's straighforward implementation. Every single place, where there were call for (or with) TilesManager, now has a DocumentObserver as companion. The m_tiledManager reference in PagePrivate was changed to QMap<DocumentObserver, TilesManager>.
REVIEW: 113986
Fix adding and removing bookmarks in the thumbnail panel
Add and removal of bookmarks via the thumbnail context menu was acting
on the current viewport instead of the clicked page. This patch checks
whether it should act on the viewport or in the right clicked page.
BUGS: 323267
FIXED-IN: 4.11.5
Because a cached dialog stays parented to the initial part, which might
not be the one used to open it.
This is especially visible now that we support more than one window per
okular process.
For example:
- User initially opens a dialog from window A
-> This dialog gets cached as child of A's PageView. This implies that
clicking on the dialog also brings window A to foreground.
- User re-opens the dialog from a different window B
-> The dialog is still a child of A's PageView, therefore clicking on the
dialog's frame brings A to the foreground, and B to the background.
Instead of listening on KConfigDialog's signals, this patch makes parts
listen on Okular::Settings::self()'s configChanged() signal.
Unlike KConfigDialogs, Okular::Settings::self() is unique and never
changes during the process lifetime, and therefore:
- A part can connect during initialization and receive notifications,
without depeding on KConfigDialog objects (which might be instanced
or deleted by a different part).
- The connection now survives deletion of the KConfigDialog.
Just use the pointer as id :-)
This is BIC and SIC, increase the soversion now to makes sure we don't forget in the future
Patch based in an earlier patch by Bogdan Cristea <cristeab@gmail.com>
REVIEW: 109115
Albert Astals Cid
Vishesh Handa
Frederik Gladhorn
Frederik Gladhorn
Luigi Toscano
Jonathan Doman
Saheb Preet Singh
Michal Humpula
Yuri Chornoivan
Mailson Menezes
Fabio D'Urso
Stefan Radermacher
Tomáš Poledný
Jaydeep Solanki