Those two categories are usually longer messages and more
important, so more fit for a (new) KMessageWidget; simple
notice signals still go to PageViewMessage into PageView.
A more general review of all the messages should be probably
performed in order to assign proper categories to them.
Reviewed by: Albert Astal Cid
Opened a file with all pages with same size and behaves exactly like Okular does
Opened a file with pages with different sizes and behaves like Okular does until it stops fiting. In that moment the page bar is not centered anymore to let the text still fit and once the text doesn't fit anymore it starts getting ellided.
Reviewed by Luigi
BUGS: 333349
FIXED-IN: 4.13.1
In an ideal world I would have commented this in reviewboard and Saheb would
have fixed it, but Feature Freeze is almost here so I decided just to fix it myself
It's straighforward implementation. Every single place, where there were call for (or with) TilesManager, now has a DocumentObserver as companion. The m_tiledManager reference in PagePrivate was changed to QMap<DocumentObserver, TilesManager>.
REVIEW: 113986
Fix adding and removing bookmarks in the thumbnail panel
Add and removal of bookmarks via the thumbnail context menu was acting
on the current viewport instead of the clicked page. This patch checks
whether it should act on the viewport or in the right clicked page.
BUGS: 323267
FIXED-IN: 4.11.5
Because a cached dialog stays parented to the initial part, which might
not be the one used to open it.
This is especially visible now that we support more than one window per
okular process.
For example:
- User initially opens a dialog from window A
-> This dialog gets cached as child of A's PageView. This implies that
clicking on the dialog also brings window A to foreground.
- User re-opens the dialog from a different window B
-> The dialog is still a child of A's PageView, therefore clicking on the
dialog's frame brings A to the foreground, and B to the background.
Instead of listening on KConfigDialog's signals, this patch makes parts
listen on Okular::Settings::self()'s configChanged() signal.
Unlike KConfigDialogs, Okular::Settings::self() is unique and never
changes during the process lifetime, and therefore:
- A part can connect during initialization and receive notifications,
without depeding on KConfigDialog objects (which might be instanced
or deleted by a different part).
- The connection now survives deletion of the KConfigDialog.
Just use the pointer as id :-)
This is BIC and SIC, increase the soversion now to makes sure we don't forget in the future
Patch based in an earlier patch by Bogdan Cristea <cristeab@gmail.com>
REVIEW: 109115
SlotDoFileDirty tries to reload the file at regular intervals.
This patch fixes it so that it can actually reopen the file even if
it is not ready at the first timer shot.
BUG: 310531
As a side effect, this change fixes bug 303998, that caused a crash if
the part's widget was destroyed before the part itself, because
m_findBar had already been destroyed.
BUG: 303998
FIXED-IN: 4.9.0
As a side effect, this change fixes bug 303998, that caused a crash if
the part's widget was destroyed before the part itself, because
m_findBar had already been destroyed.
BUG: 303998
FIXED-IN: 4.9.0
Instead of directly killing the search in the core, emit a signal
caught by FindBar to tell its SearchLineEdit to reset the search
operation.
In this way, SearchLineEdit can set m_changed, and next time a new
search operation will be started, instead of attempting to use the
old one.
Instead of directly killing the search in the core, emit a signal
caught by FindBar to tell its SearchLineEdit to reset the search
operation.
In this way, SearchLineEdit can set m_changed, and next time a new
search operation will be started, instead of attempting to use the
old one.
The only affected generator is poppler (because it's the only one with
saving support).
Since version 0.20, Poppler can save annotations to PDF. If the user is
using an older version, this patch warns him that annotations are not
saved.
Luigi Toscano
Albert Astals Cid
Jonathan Doman
Saheb Preet Singh
Michal Humpula
Yuri Chornoivan
Mailson Menezes
Fabio D'Urso
Stefan Radermacher
Tomáš Poledný
Jaydeep Solanki
Sandro Mani
Sebastian Dörner