There's always at least one tab since an okularpart is created at startup.
The supported minetypes are always read from this so fileFormats is never called.
find . \( -name "*.cpp" -or -name "*.h" -or -name "*.c" -or -name "*.cc" \) -exec clang-format -i {} \;
If you reached this file doing a git blame, please see README.clang-format (added 2 commits in the future of this one)
Create a new new annotation toolbar to replace the current one as discussed in the task T8076.
Fixes:
BUG: 386578
BUG: 374728
BUG: 352310
BUG: 330518
BUG: 341914
BUG: 157289
BUG: 358057
BUG: 412767
BUG: 413595
BUG: 420462
FIXED-IN: 1.11.0
Test Plan
Before testing this revision
Delete or Temporary move aside the following files:
~/.config/okularpartrc
~/.config/okularrc
~/.local/share/kxmlgui5/okular/part.rc
~/.local/share/kxmlgui5/okular/shell.rc
Nomenclature
Actions in the main toolbar:
Quick annotations
Actions in the annotation toolbar:
Annotation actions Highlighter, Underline, Squiggle, Strike out, Typewriter,
Inline note, Popup note, Freehand line, Arrow, Straight line, Rectangle, Ellipse,
Polygon, Stamp
Annotation config actions Line width, Color, Inner color, Opacity, Font, Annotation settings
Other actions Add to Quick Annotations, Pin
Autotests
First run: annotation toolbar is not visible
Selecting Tools > Annotations shows the annotation toolbar (below the main toolbar by default)
Select an annotation > toolbar is shown
Select a quick annotation > toolbar is shown
Hide action (red cross) on the toolbar hides the toolbar
Keys 1-9,0 select the (builtin) Annotation actions (one case tested)
Keys Alt+1-9,0 select the quick annotation actions (one case tested)
No annotation action selected: Quick Annotations is enabled, Add to quick annotations is disabled, Annotation config actions are disabled, Pin is enabled
The current document is an image: Highlighter, Underline, Squiggle, Strike out are disabled (also in Quick annotations)
The current document is protected: All actions are disabled
Select annotation: the Annotation config actions are enabled and their values set to the ones for the current annotation (taken from okularpartrc)
Click an annotation action when none selected: browse mode is selected
Click the currently selected annotation action: the action is unchecked and the tool disabled (back to browse mode)
Click ESC: the currently selected annotation action is unchecked
If Pin unchecked the selected annotation is unchecked after it has be used once and we are back to Browse mode
The annotation systems works when multiple Okular tabs are open (the selected annotation is per-tab)
Manual tests
(TODO) Check that kconf_update updates the key AnnotationTools to QuickAnnotationTools in ~/.config/okularpartrc
Color icon is a format-text-color (if inline note or typewriter) or format-stroke-color for all other annotations
All actions have tooltips (some change based on the fact that the icon is enabled or not)
If a custom Line Width or Opacity is set through the Annotation Settings dialog, its value appears as a new checked action in the Line width or Opacity menu
If a custom stamp is selected through the Annotation Settings dialog, its name or filename (without path) appears as a new checked action in the Stamp menu
In Configure Okular > Annotations it is only possible to configure the quick annotations. Modifying them here updates the Quick annotations list after clicking Apply
The current document is an image: Highlighter, Underline, Squiggle, Strike out are disabled in Quick annotations
The state of Pin action is remembered across Okular launches
Selecting a quick action selects the corresponding action and loads its config values (color, line width, ...)
Setting the color and fill color works for all annotations (to be tested carefully, can be problematic for typewriter and inline note given the different internal mechanism to store the color in the settings)
Test stamp annotation (handled differently from the rest of the annotations)
Merge Request: https://invent.kde.org/graphics/okular/-/merge_requests/105
Some discussions at https://phabricator.kde.org/D25484.
This MR adds:
* mouse middle button event handler for closing a tab
* an `undo close tab` action
Test plan:
1. Compile and install.
2. Enable `Open new files in tabs`.
3. Open two documents. They should be opened in two tabs in the same window.
4. Middle click one of the tabs. It should be closed.
5. Choose `File`-`Undo close tab`. The closed tab should be reopened.
6. Middle click one of the tabs. It should be closed.
7. Press <kbd>Ctrl</kbd>+<kbd>Shift</kbd>+<kbd>T</kbd>. The closed tab should be reopened.
Since unfortunately some of the autogenerated includes don't pass the
checks we do a trick of building out of source and then specifying the
.*/okular/.* path as the only includes we care about
Don't go through QUrl -> QString -> QUrl when opening files from the
argument list.
Don't be strict when opening URLs that come from the dbus interface.
REVIEW: 127042
Try fixing mainshelltest: one more passes now
QUrl is not automatically exposed to DBus so the DBus call would fail.
Changed the parameter to QString instead so that DBus invocation works.
mainshelltest: set QStandardPaths to test mode
Parse command line flags with a single dash as a long option
Unlike KCmdLineArgs QCommandLineParser treats options starting with a
single minus as multiple short options by default.
Previously okular -unique would fail with the following error:
Unknown options: u, n, i, q, u, e.
Also changed mainshelltest to use two dashes in case this behaviour
should change in the future.
mainshelltest failures have been reduced from 15 to 4 by this commit.
Fix docdata saving and added a warning message if it fails
If the ~/.local/okular/docdata directory didn't exist previously
creating the docdata file would fail as there are missing paths.
It seems that KStandardDirs used to create the okular/docdata directory
automatically, with QStandardPaths we have to create it manually.
mainshelltest is down to one failed test now
Fix final test case in mainshelltest
as we call QProcess::terminate the exit code will not be 0
REVIEW: 126192
Our goal is better integration with Plasma and other KDE components.
We have made a conscious decision to reduce our code a bit by removing
the legacy #ifdefs. That way we do not have to support a build
configuration which is going to be used by just a tiny minority of our
users, and one that we are not terribly interested in. Without
KActivities, there is for example no support for recording and listing
of recent documents, PDF sharing etc etc, and we honestly believe that
the majority of our audience wants these features.
REVIEW: 123249
Use a QString to serialize the command line options other than urls to open so it can be easily passed around to every place that opens a new shell or tab or overrides the content in a unique instance.
BUGS: 334100
FIXED-IN: 4.14.0
REVIEW: 119595
Stop being too smart for own our good, try to merge open and openRecent actions in just one action
confuses the hell out of people, so let's KISS and just make open recent be open recent
BUGS: 302358
BUGS: 251335
FIXED-IN: 4.10.0
This patch turns Okular into a ReadWritePart. Annotation editing is always
disabled if we're loaded as ReadOnlyPart, no matter the document type.
REVIEW: 105020
- on command line, properly read the URL ref ('#foobar' at the end), avoiding a KCmdLineArgs behaviour which encodes it as part of the file name
- pass what was specified as ref or the page (as specified with -p/--page) to the kpart
- make the okularpart take out the ref from the URL it opens and then:
a) if it is a number, assume it is the destination page number
b) otherwise, use that string as named destination
CCMAIL: okular-devel@kde.org
svn path=/trunk/KDE/kdegraphics/okular/; revision=969227
Jiří Wolker
Albert Astals Cid
Nicolas Fella
Alexander Lohnau
Michael Augaitis
Simone Gaiarin
Andi Sardina Ramos
Bob Bai
Laurent Montel
Yuri Chornoivan
Oliver Sander
Martin T. H. Sandsmark
Aleix Pol
Alex Richardson
Ivan Čukić
Saheb Preet Singh
Jonathan Doman
Sergio Martins
Frederik Gladhorn
Rohan Garg
Vishesh Handa
Frederik Gladhorn
Fabio D'Urso
Jaydeep Solanki
Aurélien Gâteau
Pino Toscano