Summary:
BUG: 182994
Adds an option to the config dialog that enables background color (the color around the displayed page) to be changed (while by default preserving the Qt toolkit selection as not to affect existing users).
Reasons for this change:
Accessibility, eye strain, aesthetic reasons, color displayed on monitor can affect power consumption (how: depends on display technology).
Many people want this change occording to Bugzilla and other sources.
Maintenance: Nearly no additional maintenance:
This is no new subsystem but a trivial feature with no complex code dependencies, and we are already showing a colour selection dialog and setting colours in other places in Okular.
{F4257766}
Other less important information:
https://git.reviewboard.kde.org/r/130219/https://mail.kde.org/pipermail/okular-devel/2017-September/025520.html
Test Plan:
Tested everything, it all works:
Toggled the custom background color, changed custom background color, removed okular settings file (with: "rm ~/.config/okular*") to verify it uses the usual qt theme colour by default (where the settings file remembered the custom color).
Reviewers: #okular, aacid, elvisangelaccio, rkflx, ngraham
Reviewed By: ngraham
Subscribers: aacid, ltoscano, ngraham
Tags: #okular
Differential Revision: https://phabricator.kde.org/D8051
Summary:
BUG: 182994
Adds an option to the config dialog that enables background color (the color around the displayed page) to be changed (while by default preserving the Qt toolkit selection as not to affect existing users).
Reasons for this change:
Accessibility, eye strain, aesthetic reasons, color displayed on monitor can affect power consumption (how: depends on display technology).
Many people want this change occording to Bugzilla and other sources.
Maintenance: Nearly no additional maintenance:
This is no new subsystem but a trivial feature with no complex code dependencies, and we are already showing a colour selection dialog and setting colours in other places in Okular.
{F4257766}
Other less important information:
https://git.reviewboard.kde.org/r/130219/https://mail.kde.org/pipermail/okular-devel/2017-September/025520.html
Test Plan:
Tested everything, it all works:
Toggled the custom background color, changed custom background color, removed okular settings file (with: "rm ~/.config/okular*") to verify it uses the usual qt theme colour by default (where the settings file remembered the custom color).
Reviewers: #okular, aacid, elvisangelaccio, rkflx, ngraham
Reviewed By: ngraham
Subscribers: aacid, ltoscano, ngraham
Tags: #okular
Differential Revision: https://phabricator.kde.org/D8051
Change the ViewMode to be an Enum instead of an ugly int and fix the ugly code accordingly. This will break your ViewMode config, i'm sorry for that
Move the setting for centered pages to the view mode as people seems to be having a lot of difficulties of finding it in the old location
svn path=/trunk/KDE/kdegraphics/okular/; revision=1072353
- move the Center first page in row from the Features to the View options group, and state that it works not only in facing mode
- remove the Overview rows, never working
svn path=/trunk/KDE/kdegraphics/okular/; revision=694382
- render the viewed rect area in the thumbnail a bit more elegantly
- Render Mode -> View Mode ... "render" is geekanese, "view" is proper luserian
svn path=/trunk/playground/graphics/okular/; revision=604731
Albert Freeman
Luigi Toscano
Nathaniel Graham
Albert Astals Cid
Olivier CHURLAUD
Montel Laurent
Thomas Fischer
Yuri Chornoivan
Sandro Mani
Albert Astals Cid
Michal Svec
Martin Ueding
Andrius Štikonas
Christoph Feck
Pino Toscano
Aaron J. Seigo