Source files are no longer separated by UI and non-UI and similar,
but only by their build target.
* ui/ -> part/
* Move all source files from conf/ to part/
* Keep config skeleton definitions in conf/, needed for the mobile target too
* Move editdrawingtooldialogtest.h from conf/autotests/ to autotests/
* ui/data/icons/ -> icons/
* Move /part.cpp, /part.rc and similar files to part/
* Adapt include paths in source files
* Adapt CMakeLists.txt files (in / and in subdirectories)
* Adapt /Messages.sh
find . \( -name "*.cpp" -or -name "*.h" -or -name "*.c" -or -name "*.cc" \) -exec clang-format -i {} \;
If you reached this file doing a git blame, please see README.clang-format (added 2 commits in the future of this one)
Okular's sidebar vertical view chooser toolbar suffers from a few issues:
* It's a nonstandard UI not used for category choosers in other pieces of KDE software,
and not used in other FOSS document readers
* What is shown and what is hidden is simultaneously too configurable while still not
offering the desirable UI common to other programs (i.e. no visible category chooser,
but a sidebar capable of displaying thumbnails, table of contents, search results, etc.)
* With labels on it takes up quite a bit of horizontal space, while with labels off, the
categories are less than clear
* UX is kind of clunky with nonstandard behaviors (e.g. clicking on the current category
to hide that category's view while keeping the view chooser visible, showing mostly
disabled items)
* It's made with custom painting code, which reduces maintainability and introduces bugs
(e.g. https://bugs.kde.org/show_bug.cgi?id=408190)
This patch removes the vertical category chooser entirely and replaces it with a tabbed
view on the top of the sidebar itself. The tabs are icons-only and have large icons. A
button is added on the left side of the default toolbar to quickly hide or show the
sidebar. In order to make room for the new button, the Previous and Next buttons on the
toolbar are removed, as previous/next buttons are already present on the Page Bar on the
bottom of the window so there's no need to duplicate this functionality. This improves
the UX, fixes a variety of bugs, and deletes a lot of custom code of dubious long-term
maintainability.
BUG: 213508
BUG: 334441
BUG: 344599
BUG: 408190
CCBUG: 335189
FIXED-IN: 1.11.0
CHANGELOG: The sidebar can now be easily shown or hidden with a toolbar button, and the category chooser no longer takes up so much space
Use jq to filter compile_commands.json to not include the compilation of
autogenerated files, we don't want to check those
Also filter out the synctex folder, since that is imported code
Since unfortunately some of the autogenerated includes don't pass the
checks we do a trick of building out of source and then specifying the
.*/okular/.* path as the only includes we care about
Just use the pointer as id :-)
This is BIC and SIC, increase the soversion now to makes sure we don't forget in the future
Patch based in an earlier patch by Bogdan Cristea <cristeab@gmail.com>
REVIEW: 109115
Instead of putting in the scrollarea as many widgets as the number of pages, just paint the thumbnails on the scroll widget itself;
this should reduce a bit the memory usage due to the child widgets (especially in documents w/ many pages).
All should work as before, even the few annoyances with the visible areas drag were left (now they can be solved).
svn path=/trunk/KDE/kdegraphics/okular/; revision=765585
number, the total number of pages and a little grahical 'progress'
indicator. Moved 'next page' and 'prev page' buttons from the main toolbar
to the MiniBar. Minibar lets you edit the page number, click or wheel on
progress, go to next/prev page, show the gotoPage dialog.
Added rmb popup when clicking on thumbnails. When clicking, the
ThumbnailList only emits the same signal emitted by PageView so the same
context menu is displayed.
Misc fixes: [MEM] enabled allocated pages raising in queue when displayed
again, [ThumbnailList] enabled PageUp/PageDown.
svn path=/trunk/kdegraphics/kpdf/; revision=382597
Display contents faster, waste less memory. Added preloading to forward-
generate pages (if threading enabled and memory profile >= normal). Main
pages are always generated first, then thumbnails come, then preload ones,
etc.. Btw memory and cpu will be happier now.
(1 bug in memory and 1 in preloading still remains.. will be spotted soon)
For Developers:
Generator: dropped moc, api changes, better functions naming.
PDFGenerator and Document: moved requests queue to the Document.
The generator performs only a single request a time. A flag can be
queried to know if the generator is ready for starting another pixmap
generation or not (in case it's generating a pixmap in background).
PixmapRequest: added priority and backgound (async) attributes.
Document: queuing requests by priority in requestPixmaps.
Observer: added defines for priorities used in doc->requestpixmaps.
PageView: delayed find-ahead timer creation (not created if not needed).
Added preload PixmapRequests to the pixmap requests list.
ThumbnailsList: adapted to pixmapRequest changes and changed naming for
delayed thumbanils request.
svn path=/trunk/kdegraphics/kpdf/; revision=379820
A const reference may be asked. When set all DocumentObservers will be
notified so they can update their gfx if needed. Converted TOC, Links
to the new usage. DocumentViewport can be saved/restored to/from QString
so it can be asked as metadata and saved on document's XML. When loading
a document the viewport is restored exactly where it was when the document
was closed. More fixes with Viewport class. Swapped groupboxes in Perform
dialog. Changed members naming in DocumentObservers and inherited classes.
PageView and ThumbnailsList now linked.
Still regressions / TODOs about the Viewport thing.
svn path=/trunk/kdegraphics/kpdf/; revision=377066
filtering and similar options (toolbar is not created now). Changed
Document::openDocument(..) functions order. Restore last active page when
opening an already viewed pdf. Fix margins around pages in all modes.
Presentation: page change by clicking on the round 'wheel' indicator too.
Updated TODO.
svn path=/trunk/kdegraphics/kpdf/; revision=375229
for the file naming map and file versioning. Please wait until the commit
storm ends to report any bug. Albert and Enrico
Compile fixes.
svn path=/trunk/kdegraphics/kpdf/; revision=374941
for the file naming map and file versioning. Please wait until the commit
storm ends to report any bug. Albert and Enrico
Moved KPDFDocumentObserver in its own include file. Updated dependancies.
svn path=/trunk/kdegraphics/kpdf/; revision=374928
for the file naming map and file versioning. Please wait until the commit
storm ends to report any bug. Albert and Enrico
File namings change.
svn path=/trunk/kdegraphics/kpdf/; revision=374924
Alexander Lohnau
David Hurka
Albert Astals Cid
Nate Graham
Laurent Montel
Yuri Chornoivan
Albert Vaca
Olivier CHURLAUD
Martin T. H. Sandsmark
Jonathan Doman
Tobias Koenig
Brad Hards
Pino Toscano
Dirk Mueller
Albert Astals Cid
Enrico Ros