okular

Commit Graph

Author	SHA1	Message	Date
Simone Gaiarin	4e0c1690d2	Uniform the case of the 'Id' suffix in variable names	6 years ago
Simone Gaiarin	cd96735ae2	Maintain quick annotation shortcut compatibility with Okular < 1.11.0 During the upgrade to Okular 1.11.0 the shortcuts for the quick annotations have been changed from the keys 1, 2, 3,... to Alt + 1, 2, 3,... making some users unhappy. CCBUG: 426009	6 years ago
David Hurka	076e17c608	Create GuiUtils functions createColorIcon() and createOpacityIcon() * createColorIcon creates a QIcon which visualizes the given colors using rectangles. A background icon can be provided, in that case only the lowest 25% of the icon will be filled by the rectangles. * createOpacityIcon creates a QIcon that visualizes a given opacity using the current foreground color and a checkerboard background. These functions are now used in place of colorIcon, colorPicerIcon, opacityIcon in AnnotationActionHandler. The new functions have some advantages: support most common icon sizes, and dark color schemes.	6 years ago
Simone Gaiarin	bc2d22910a	Improve robustness of code against corrupted configurations Perform extra checks on the existence of QDomElement attributes and on the correctness of their conversion from QString to int. This also prevents a crash if it is not possible to find the built in tool associated to the triggered quick tool.	6 years ago
Simone Gaiarin	72f5a2db08	Find built-in tool corresponding to quick tool at runtime In this way it is possible to drop the `sourceId` attribute from the quick tools definition. This simplifies the code logic and makes it easier to update user settings from the previous version of Okular (because there is no need to add the attribute `sourceId` This also fixes the crash due to the fact that `sourceId` was not correctly created when a quick annotation is created from the Annotation page of Okualr Settings. BUG: 424810 FIXED-IN: 1.11.0	6 years ago
Simone Gaiarin	558742a009	Ensure "Quick annotations" action is always disabled on protected pdf If the annotations are disabled in the current pdf we can skip repopulating "Quick annotations" and in this way we also assure that the enabled/disabled state of the action is preserved upon configuration reparsing. d->toolsEnabled must be initialized to true, in order to correctly populate the "Quick annotations" action the first time for non-protected pdf, given that setToolsEnabled is called after the first call to populateQuickAnnotations. BUG: 424296 FIXED-IN: 1.11.0	6 years ago
David Hurka	34708565ca	Add Constrain Angle action for annotation tools, alternative to pressing Shift This adds a KToggleAction which sets annotation tools to constrain angle mode. It provides an alternative user interface to the Shift button, which is used to constrain angles since MR !210. The action and the Shift button are XOR-ed, i. e. if constrain angle mode is activated, pressing Shift temporarily disables it. The action state is remembered accross sessions, for consistency with most other actions. It should be difficult to check this action without knowing of its existence, since it is not in any toolbar or menu, just in the action collection. The meaning of AnnotatorEngine::Modifiers was generalized a bit, moving the responsibility about whether to constrain angles back to PageViewAnnotator, because AnnotatorEngine does not know about the action. FEATURE: 353560 FIXED-IN: 1.11	6 years ago
Simone Gaiarin	bba13ee566	Add tooltip to "Quick Annotations"	6 years ago
Simone Gaiarin	f2338f4022	Make connection unique for annotation visibility actions This event is sent three times at startup and two times per tab at tab change, so let's make sure we setup the connections only once.	6 years ago
Albert Astals Cid	19d98d6a74	Run clang-format find . \( -name ".cpp" -or -name ".h" -or -name ".c" -or -name ".cc" \) -exec clang-format -i {} \; If you reached this file doing a git blame, please see README.clang-format (added 2 commits in the future of this one)	6 years ago
Simone Gaiarin	0b05d7ce99	Overhaul annotations UX Create a new new annotation toolbar to replace the current one as discussed in the task T8076. Fixes: BUG: 386578 BUG: 374728 BUG: 352310 BUG: 330518 BUG: 341914 BUG: 157289 BUG: 358057 BUG: 412767 BUG: 413595 BUG: 420462 FIXED-IN: 1.11.0 Test Plan Before testing this revision Delete or Temporary move aside the following files: ~/.config/okularpartrc ~/.config/okularrc ~/.local/share/kxmlgui5/okular/part.rc ~/.local/share/kxmlgui5/okular/shell.rc Nomenclature Actions in the main toolbar: Quick annotations Actions in the annotation toolbar: Annotation actions Highlighter, Underline, Squiggle, Strike out, Typewriter, Inline note, Popup note, Freehand line, Arrow, Straight line, Rectangle, Ellipse, Polygon, Stamp Annotation config actions Line width, Color, Inner color, Opacity, Font, Annotation settings Other actions Add to Quick Annotations, Pin Autotests First run: annotation toolbar is not visible Selecting Tools > Annotations shows the annotation toolbar (below the main toolbar by default) Select an annotation > toolbar is shown Select a quick annotation > toolbar is shown Hide action (red cross) on the toolbar hides the toolbar Keys 1-9,0 select the (builtin) Annotation actions (one case tested) Keys Alt+1-9,0 select the quick annotation actions (one case tested) No annotation action selected: Quick Annotations is enabled, Add to quick annotations is disabled, Annotation config actions are disabled, Pin is enabled The current document is an image: Highlighter, Underline, Squiggle, Strike out are disabled (also in Quick annotations) The current document is protected: All actions are disabled Select annotation: the Annotation config actions are enabled and their values set to the ones for the current annotation (taken from okularpartrc) Click an annotation action when none selected: browse mode is selected Click the currently selected annotation action: the action is unchecked and the tool disabled (back to browse mode) Click ESC: the currently selected annotation action is unchecked If Pin unchecked the selected annotation is unchecked after it has be used once and we are back to Browse mode The annotation systems works when multiple Okular tabs are open (the selected annotation is per-tab) Manual tests (TODO) Check that kconf_update updates the key AnnotationTools to QuickAnnotationTools in ~/.config/okularpartrc Color icon is a format-text-color (if inline note or typewriter) or format-stroke-color for all other annotations All actions have tooltips (some change based on the fact that the icon is enabled or not) If a custom Line Width or Opacity is set through the Annotation Settings dialog, its value appears as a new checked action in the Line width or Opacity menu If a custom stamp is selected through the Annotation Settings dialog, its name or filename (without path) appears as a new checked action in the Stamp menu In Configure Okular > Annotations it is only possible to configure the quick annotations. Modifying them here updates the Quick annotations list after clicking Apply The current document is an image: Highlighter, Underline, Squiggle, Strike out are disabled in Quick annotations The state of Pin action is remembered across Okular launches Selecting a quick action selects the corresponding action and loads its config values (color, line width, ...) Setting the color and fill color works for all annotations (to be tested carefully, can be problematic for typewriter and inline note given the different internal mechanism to store the color in the settings) Test stamp annotation (handled differently from the rest of the annotations) Merge Request: https://invent.kde.org/graphics/okular/-/merge_requests/105	6 years ago

12 Commits (1784c1d0cb2ca79983d138bbdd0b9f681f7beb7b)