Summary:
We request a inhibit lock of DBus type UNIX_FD from systemd logind. It's wrapped into (and owned by) a QDBusUnixFileDescriptor object of automatic storage. The file descriptor will be closed in QDBusUnixFileDescriptor Dtor, and may be reused by some other facility (e.g. pulseaudio).
If we want to store the lock longer than QDBusUnixFileDescriptor lifetime, we have to dup the file descriptor. If we don't dup, and close the original fd later in PresentationWidget::allowPowerManagement, bad things may happen.
Besides that, what we get from systemd is really a file descriptor, not a "cookie". So I renamed the m_sleepInhibitCookie to m_sleepInhibitFd and changed initial state to -1 accordingly.
BUG 393478
BUG 398720
Test Plan:
- bugs don't occur any longer
- inhibiting sleep during presentation mode still works
Reviewers: aacid
Reviewed By: aacid
Subscribers: ngraham, anthonyfieroni, okular-devel
Tags: #okular
Differential Revision: https://phabricator.kde.org/D15574
Summary:
This patch enables HiDPI throughout the application
Every pixmap is multiplied by the devicePixelRatioF
QPainter code is ajusted to take the DPR value into account
All pixmaps get cached with the highest DPR of all screens. When moving the application to another screen, the cache doesn't have to be invalidated.
BUGS: 362856 383589
REVIEW: D6268
Right now, fade transition is always done in 100 frames. If the intended duration is, say, 1 second, the actual duration can easily be a few seconds instead, due to the limited CPU power (on my laptop with core i5, those 100 frames take 2 seconds).
I propose a patch that changes the number of frames to 20 * (duration in seconds). 20 FPS still looks completely smooth to me.
REVIEW: 125310
BUGS: 352876
Extend the drawing tool section in top bar with an eraser tool,
which removes parts of the lines that have been drawn before.
FEATURE: 343774
REVIEW: 124689
3 benefits:
* We can set the shortcut in the edit shortcuts dialog as before
* Shortcuts can be activated without showing the topbar as before
* Drawing in the toppbar is exactly as the other actions
That patch extracts the video file, which is defined in a
rich media annotation as parameter for the flash player,
and uses the normal multimedia player, to playback the video
file.
This feature requires poppler-qt5 in version 0.36.
FEATURE: 326230
REVIEW: 124612
Fixes the case in which the page has duration, and Okular::SettingsCore::slidesAdvanceTime is smaller than the page duration but autoAdvance is disabled
BUGS: 340035
In an ideal world I would have commented this in reviewboard and Saheb would
have fixed it, but Feature Freeze is almost here so I decided just to fix it myself
Just use the pointer as id :-)
This is BIC and SIC, increase the soversion now to makes sure we don't forget in the future
Patch based in an earlier patch by Bogdan Cristea <cristeab@gmail.com>
REVIEW: 109115
Tobias Deiminger
Yuri Chornoivan
Lukas Hetzenecker
Kevin Funk
Alexander Schlarb
Albert Astals Cid
Oliver Sander
Martin T. H. Sandsmark
Albert Vaca
Aleix Pol
Gleb Popov
Olivier CHURLAUD
Oliver Sander
Montel Laurent
Arseniy Lartsev
Tobias Koenig
Tobias Koenig
Saheb Preet Singh
Lukáš Tinkl
Frederik Gladhorn
Vishesh Handa
Frederik Gladhorn