Summary:
There's two issues here:
- Activity::onCreate triggered before the C++ side was loaded, so the
call to C++ failed (causing a crash). So delay that until we are ready.
- The static instance of URIHandler in the header caused it to duplicate
into each translation unit, causing main.cpp to not see what android.cpp
wrote into it.
Subscribers: okular-devel
Tags: #okular
Differential Revision: https://phabricator.kde.org/D18399
Summary: The bug was that the Drawer use the `drawerOpen` properties now instead of just `open`. Also fix deprecation Kirigami.Label -> QQC2.Label.
Test Plan: Tested on my computer with the touchpad. I could potentialy try with my android phone, if needed.
Subscribers: okular-devel
Tags: #okular
Differential Revision: https://phabricator.kde.org/D18637
Summary:
If a link spans more than one line we need one rect for each of the lines
BUGS: 403247
Subscribers: okular-devel
Tags: #okular
Differential Revision: https://phabricator.kde.org/D18303
Summary:
Some people need them
BUG: 403445
Test Plan: Can be compiled, installed, can be spotted in the GUI.
Reviewers: #okular, ngraham
Reviewed By: ngraham
Subscribers: ngraham, #vdg, GB_2, okular-devel
Tags: #okular
Differential Revision: https://phabricator.kde.org/D18429
This is a squash of the original branch
It also contains fixes/rework from Albert Astals Cid
If you're interested in its history have a look at the
gsoc2018_digitalsignature branch
The poppler dependency situation is:
* With 0.51 you get most signature information
* With 0.68 you also get signature location/reason information
* With 0.73 you also get signature certificate information
We don't use it and it had problems if you tried to use the copy
constructor or the assignment operator so better just remove it.
I'm unusure if this is binary incompatible, but oh well
I.e. make sure they have destructor, copy constructor and asignment
operator
They don't really need them since it's plain data that can be copied
with the defaul implementations (which is actually what i am using) but
since we had some of them implemented and some not, clazy was
complaining that this is generally a bad idea, so implement them all
they are unused(except the PageViewItem one), but if anyone would use
them things would go wrong, so protect us from it
Actually fixes a bug in PageView::slotFitWindowToPage in which we were
copying constructing PageViewItem and that's bad
Summary: It is sometimes untrivial for ordinary user to find the right options to print PDF. It should be documented somehow.
Test Plan: Tested woth checkXML5
Reviewers: #okular, #documentation, ngraham
Reviewed By: ngraham
Subscribers: ngraham, okular-devel, kde-doc-english
Tags: #okular, #documentation
Differential Revision: https://phabricator.kde.org/D17749
This patch introduces the choice between three scaling
options for printing:
* Fit to printable area
* Fit to full page
* No scaling
The new options only work with the QPrinter backend. Therefore
they are only enabled if 'force rasterization' is selected.
Differential Revision: https://phabricator.kde.org/D7962
It is more logical to have the drawing tools first, then the eraser,
and then the action to delete everything. Also the two actions to erase
things are close to each other now.
The icon of "erase drawing" has been changed to draw-eraser-delete-objects
to distinguish it from the "Eraser" tool.
BUG: 399734
Differential Revision: https://phabricator.kde.org/D16171
Shubham Jangra
Volker Krause
Christoph Feck
Carl Schwan
Albert Astals Cid
l10n daemon script
Nate Graham
Yuri Chornoivan
Alexander Volkov
Chinmoy Ranjan Pradhan
Aleix Pol
Iñigo Salvador Azurmendi
Oliver Sander
Simone Gaiarin