When the second instance is launched it receives an activation token per environment variable
We need to pass that token to the first instance so that it can use it to raise itself
Also properly use startup ids for this on X11 instead of relying on forceActiveWindow, which is a hack
With this MR, the sidebar can now be (if not locked):
* docked to the left or right side
* undocked and floated as an independent window
* closed with the close button in the header
BUG: 455013
Better enforce them now, so that the work to port doesn't increase over
time
Not a super fan of this for regular applications, but oh well the ship
has sailed
There's always at least one tab since an okularpart is created at startup.
The supported minetypes are always read from this so fileFormats is never called.
Okular's current default window size is very small, due to a bug which
will be fixed by
https://invent.kde.org/frameworks/kxmlgui/-/merge_requests/53. Once that
is fixed, its default window size will become huge due to the current
sizeHint value, which basically says "take up 75% of the screen space".
This may be somewhat excessive.
This commit reduces the sizeHint to a saner default size while still
being big enough to show all toolbar buttons.
f9841b0f8a and e0f45add55
They break the windows build, which shows there's something defenitely
fishy going on with the current code, but oh well, someone with more
time needs to figure out a proper solution
It was causing problems (Windows build fails) now that we enabled -Wweak-vtables (and
probably before didn't work that much before, guessing that's why we had that if (doc)
in openFile)
This is the simplest solution, invokeMethod is not great but we already
use it, so it's not too terrible
The openDocument function was unused so remove it.
The other two solutions are:
* Make KDocumentViewer be part of okularcore and then link the
okularcore to the okular binary, not nice
* Make another dynamic library that just contains the KDocumentViewer
class, but i'd rather not add yet another library we have to install
and take care of
And by that it means giving the focus to the pageview which is most of
the fimes what we want. One could argue that if i had the focus on the
searchbar we should restore the focus there, but that makes not much
sense to me, since each tab is it's own world, at most one could say,
let's remember where the focus was in that tab the last time it was
focused and restore it there, but it seems a bit convoluted.
To be able of setting the focus to the pageview from the shell we need
to set up some focus proxies, so that part->widget (which is the sidebar)
ends up giving the focus to the pageview, which is what makes sense if
someone says "you part, set yourself the focus"
BUGS: 428257
Only if you're on a new enough KIO, we need
a1acb7744455b57dc972b3073f6e1dce0d49d965
and
7bf4d793a5ac54280c45660dbd04de4fa99dc994
present since 5.73 to make the UI usable
BUGS: 422574
find . \( -name "*.cpp" -or -name "*.h" -or -name "*.c" -or -name "*.cc" \) -exec clang-format -i {} \;
If you reached this file doing a git blame, please see README.clang-format (added 2 commits in the future of this one)
Create a new new annotation toolbar to replace the current one as discussed in the task T8076.
Fixes:
BUG: 386578
BUG: 374728
BUG: 352310
BUG: 330518
BUG: 341914
BUG: 157289
BUG: 358057
BUG: 412767
BUG: 413595
BUG: 420462
FIXED-IN: 1.11.0
Test Plan
Before testing this revision
Delete or Temporary move aside the following files:
~/.config/okularpartrc
~/.config/okularrc
~/.local/share/kxmlgui5/okular/part.rc
~/.local/share/kxmlgui5/okular/shell.rc
Nomenclature
Actions in the main toolbar:
Quick annotations
Actions in the annotation toolbar:
Annotation actions Highlighter, Underline, Squiggle, Strike out, Typewriter,
Inline note, Popup note, Freehand line, Arrow, Straight line, Rectangle, Ellipse,
Polygon, Stamp
Annotation config actions Line width, Color, Inner color, Opacity, Font, Annotation settings
Other actions Add to Quick Annotations, Pin
Autotests
First run: annotation toolbar is not visible
Selecting Tools > Annotations shows the annotation toolbar (below the main toolbar by default)
Select an annotation > toolbar is shown
Select a quick annotation > toolbar is shown
Hide action (red cross) on the toolbar hides the toolbar
Keys 1-9,0 select the (builtin) Annotation actions (one case tested)
Keys Alt+1-9,0 select the quick annotation actions (one case tested)
No annotation action selected: Quick Annotations is enabled, Add to quick annotations is disabled, Annotation config actions are disabled, Pin is enabled
The current document is an image: Highlighter, Underline, Squiggle, Strike out are disabled (also in Quick annotations)
The current document is protected: All actions are disabled
Select annotation: the Annotation config actions are enabled and their values set to the ones for the current annotation (taken from okularpartrc)
Click an annotation action when none selected: browse mode is selected
Click the currently selected annotation action: the action is unchecked and the tool disabled (back to browse mode)
Click ESC: the currently selected annotation action is unchecked
If Pin unchecked the selected annotation is unchecked after it has be used once and we are back to Browse mode
The annotation systems works when multiple Okular tabs are open (the selected annotation is per-tab)
Manual tests
(TODO) Check that kconf_update updates the key AnnotationTools to QuickAnnotationTools in ~/.config/okularpartrc
Color icon is a format-text-color (if inline note or typewriter) or format-stroke-color for all other annotations
All actions have tooltips (some change based on the fact that the icon is enabled or not)
If a custom Line Width or Opacity is set through the Annotation Settings dialog, its value appears as a new checked action in the Line width or Opacity menu
If a custom stamp is selected through the Annotation Settings dialog, its name or filename (without path) appears as a new checked action in the Stamp menu
In Configure Okular > Annotations it is only possible to configure the quick annotations. Modifying them here updates the Quick annotations list after clicking Apply
The current document is an image: Highlighter, Underline, Squiggle, Strike out are disabled in Quick annotations
The state of Pin action is remembered across Okular launches
Selecting a quick action selects the corresponding action and loads its config values (color, line width, ...)
Setting the color and fill color works for all annotations (to be tested carefully, can be problematic for typewriter and inline note given the different internal mechanism to store the color in the settings)
Test stamp annotation (handled differently from the rest of the annotations)
Merge Request: https://invent.kde.org/graphics/okular/-/merge_requests/105
Some discussions at https://phabricator.kde.org/D25484.
This MR adds:
* mouse middle button event handler for closing a tab
* an `undo close tab` action
Test plan:
1. Compile and install.
2. Enable `Open new files in tabs`.
3. Open two documents. They should be opened in two tabs in the same window.
4. Middle click one of the tabs. It should be closed.
5. Choose `File`-`Undo close tab`. The closed tab should be reopened.
6. Middle click one of the tabs. It should be closed.
7. Press <kbd>Ctrl</kbd>+<kbd>Shift</kbd>+<kbd>T</kbd>. The closed tab should be reopened.
autotests/*, conf/* , mobile/* , shell/*, part.cpp, extension.cpp
The code compiles and all unit tests pass (except for the two that
fail on master too).
When not using frameworks integration we only get "false" in
shouldBeShownYesNo when the saved value is yes/no so set it to yes.
Also it was a bit weird before because we were using an uninitialized
value, so this is much better :)
BUGS: 409430
Eugene Popov
Nicolas Fella
Albert Astals Cid
Boris Petrov
Volker Krause
Jiří Wolker
Andreas Naumann
Yuri Chornoivan
Alexander Lohnau
Nate Graham
Michael Augaitis
Laurent Montel
Rafael Sadowski
Oliver Sander
David Hurka
Simone Gaiarin
Andi Sardina Ramos
Andi Sardina Ramos
Bob Bai
Ahmad Samir