wilderjds/okular - okular - gitea-jacopods

Author	SHA1	Message	Date
Henrik Fehlauer	dccd83783d	Prevent Okular from crashing when synctex logs an error `bd20e48c3c` updated Okular's copy of the synctex code to 1.19. Unfortunately since this version the upstream code logs errors like `"! SyncTeX Error : Ignored record...` when accessing selected synctex files created with older versions of synctex. The upstream `_synctex_log` contains `va_list arg` as a parameter, but fails to initialize and tear down this properly via `va_start` and `va_end`. In general this seems to work for the single argument case. However, once we apply our hardening patch to get rid of the `gnu_printf format attribute` warning and thus introduce a variadic argument, things go wrong. To fix this, we add the missing code. The remaining changes are just refreshing the patches. BUG: 383915 Test Plan: Opening `empty.pdf` with `empty.synctex.gz` from https://bugs.kde.org/attachment.cgi?id=109116 located in the same folder does not lead to Okular segfaulting anymore.	8 years ago
Henrik Fehlauer	b6573a2713	Change whitespace in synctex patches 15-prevent-leaks-and-segfault.diff did not apply cleanly with quilt. After fixing this, some of the other patches needed a refresh.	8 years ago
Henrik Fehlauer	bd20e48c3c	Update to synctex 1.19 Summary: This should prevent crashes when reloading some synctex-enabled pdf files created with newer versions of TeXLive. We also gain bugfixes, features and improved accuracy from the last 6 years of synctex development. Procedure followed: - svn co svn://tug.org/texlive/trunk/Build/source/texk/web2c/synctexdir - Check out revision 45150 - Update files present in core/synctex/* - Adapt Okular code to changes - Review and drop or update/apply old patches using quilt - Create missing patches for local synctex changes - New patch: Omit warning message when opening non-synctex pdf - Two new patches to fix more compiler warnings - New patch: Plug multiple leaks and prevent a segfault TODO for later: - Move sync file detection code to Okular to never call into synctex C code for non-synctex files - Evaluate feasibility of upstreaming all patches for TeXLive 2018 and using synctex as a library BUG: 383915 FIXED-IN: 17.12.0 Test Plan: - No crash in synctex on reloading empty.pdf from bugreport anymore. - Shift-clicking on a word in a simple pdf opens Kate with the corresponding tex line. - Forward and backward search in Kile seems to work. - Works with synctex files from both TeXLive 2015 and 2017. - PartTest::testForwardPDF still passes. - No additional memory leaks in autotests and with basic synctex and non-synctex usage of Okular. Reviewers: #okular, sander, #kile, aacid Reviewed By: #okular, aacid Subscribers: mludwig, aacid Tags: #okular Differential Revision: https://phabricator.kde.org/D7594	9 years ago
Albert Astals Cid	d95efa7698	Move synctex up to the core from poppler generator This way dvi and any other potential user gets it for free The diff is huge, but the synctex files are just moves. And the code in core/ is also mostly just a move from the generator_pdf.cpp code Acked by Luigi REVIEW: 120311	12 years ago
Albert Astals Cid	858442781e	Fix cpp comments	15 years ago