This was broken since commit 077689c4 when this got ported away from
KAction. The code attempted to add a parent QMenu to the QAction
instances nested below that parent. I'm quite surprised that it didn't
crash, but checkable actions do not go well with actions that have
nested menus, apparently.
I haven't checked the rest of the code for similar mistakes, but I don't
see any other case of this bug in Okular's menus when reading PDFs.
REVIEW: 124842
Extend the drawing tool section in top bar with an eraser tool,
which removes parts of the lines that have been drawn before.
FEATURE: 343774
REVIEW: 124689
3 benefits:
* We can set the shortcut in the edit shortcuts dialog as before
* Shortcuts can be activated without showing the topbar as before
* Drawing in the toppbar is exactly as the other actions
That patch extracts the video file, which is defined in a
rich media annotation as parameter for the flash player,
and uses the normal multimedia player, to playback the video
file.
This feature requires poppler-qt5 in version 0.36.
FEATURE: 326230
REVIEW: 124612
The old auto_ptr was used for simple RAII. None of the auto_ptr flaws
were apparent in that context, but given that that class is actively
deprecated and that compilers warn about its use, it's better to switch
to its drop-in replacement.
My reason for not using QScopedPointer is that the C++11 version works
well enough, Okular is being built in C++11 mode anyway, unique_ptr
works on the KF5-minimal-mandated-compilers according to their docs, and
therefore there's no point in using something with a different API
(QScopedPointer) just because its name begins with a Q.
REVIEW: 124027
Say "Play Sound" instead of "Follow this link"
Only offer to stop sound when there's one playing
Inspired by https://git.reviewboard.kde.org/r/120683 by Nidhi Jain
On 45dc1990 i made the wrong assumption that if you were in
slotRequestVisiblePixmaps with the mid mouse button pressed
it meant that you were mid mouse button zooming, but this is not
true if you mid mouse click on the scrollbar.
So the solution to ignore pixmap request on mid mouse button zooming
is actually use blockPixmapsRequest
BUGS: 341583
FIXED-IN: 14.12.1
Fixes the case in which the page has duration, and Okular::SettingsCore::slidesAdvanceTime is smaller than the page duration but autoAdvance is disabled
BUGS: 340035
Jan Kundrát
Tobias Koenig
Albert Astals Cid
Tobias Koenig
Montel Laurent
Saheb Preet Singh
René J.V. Bertin
Martin T. H. Sandsmark
Jeremy Whiting
Lukáš Tinkl
Jonathan Doman