diff --git a/CMakeLists.txt b/CMakeLists.txt index dc109d666..d999cbe4b 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -313,6 +313,7 @@ target_link_libraries(okularpart okularcore Phonon::phonon4qt5 KF5::Archive KF5::Bookmarks + KF5::I18n KF5::IconThemes KF5::ItemViews KF5::KDELibs4Support diff --git a/generators/mobipocket/CMakeLists.txt b/generators/mobipocket/CMakeLists.txt index 8ef140b27..141ba0df1 100644 --- a/generators/mobipocket/CMakeLists.txt +++ b/generators/mobipocket/CMakeLists.txt @@ -10,7 +10,7 @@ set(okularGenerator_mobi_PART_SRCS okular_add_generator(okularGenerator_mobi ${okularGenerator_mobi_PART_SRCS}) -target_link_libraries(okularGenerator_mobi okularcore ${QMOBIPOCKET_LIBRARIES} KF5::I18n Qt5::Gui KF5::KDELibs4Support) +target_link_libraries(okularGenerator_mobi okularcore ${QMOBIPOCKET_LIBRARIES} KF5::I18n Qt5::Gui) ########### install files ############### diff --git a/mobile/components/CMakeLists.txt b/mobile/components/CMakeLists.txt index a34510281..9da375fd6 100644 --- a/mobile/components/CMakeLists.txt +++ b/mobile/components/CMakeLists.txt @@ -4,7 +4,7 @@ add_definitions(${QT_DEFINITIONS}) include_directories( ${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_BINARY_DIR} - + ${QIMAGEBLITZ_INCLUDES} ) @@ -29,7 +29,7 @@ target_link_libraries(okularplugin Qt5::Xml Qt5::Svg okularcore - KF5::KDELibs4Support + okularpart ) install(TARGETS okularplugin DESTINATION ${KDE_INSTALL_QMLDIR}/org/kde/okular) diff --git a/mobile/components/okularplugin.cpp b/mobile/components/okularplugin.cpp index 93d491e68..2204bea5b 100644 --- a/mobile/components/okularplugin.cpp +++ b/mobile/components/okularplugin.cpp @@ -23,7 +23,7 @@ #include "pageitem.h" #include "thumbnailitem.h" -#include +#include #include void OkularPlugin::registerTypes(const char *uri) diff --git a/ui/guiutils.cpp b/ui/guiutils.cpp index 72986c458..14bb85cd6 100644 --- a/ui/guiutils.cpp +++ b/ui/guiutils.cpp @@ -10,12 +10,13 @@ #include "guiutils.h" // qt/kde includes -#include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include +#include #include // local includes @@ -24,7 +25,7 @@ #include "core/document.h" #include -#include + struct GuiUtilsHelper { diff --git a/ui/guiutils.h b/ui/guiutils.h index fffe04488..cbfcb0461 100644 --- a/ui/guiutils.h +++ b/ui/guiutils.h @@ -10,7 +10,7 @@ #ifndef OKULAR_GUIUTILS_H #define OKULAR_GUIUTILS_H -#include +#include class QColor; class QImage; diff --git a/ui/propertiesdialog.cpp b/ui/propertiesdialog.cpp index d6b409fc7..c8a779839 100644 --- a/ui/propertiesdialog.cpp +++ b/ui/propertiesdialog.cpp @@ -10,25 +10,26 @@ #include "propertiesdialog.h" // qt/kde includes -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include #include -#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include #include -#include -#include +#include +#include #include // local includes @@ -229,10 +230,10 @@ void PropertiesDialog::showFontsMenu(const QPoint &pos) { Okular::FontInfo fi = index.data(FontInfoRole).value(); const QString caption = i18n( "Where do you want to save %1?", fi.name() ); - const QString path = KFileDialog::getSaveFileName( QUrl::fromLocalFile(fi.name()), QString(), this, caption, KFileDialog::ConfirmOverwrite ); + const QString path = QFileDialog::getSaveFileName( this, caption, fi.name() ); if ( path.isEmpty() ) return; - + QFile f( path ); if ( f.open( QIODevice::WriteOnly ) ) { diff --git a/ui/thumbnaillist.cpp b/ui/thumbnaillist.cpp index aaca69791..bb72ef7a1 100644 --- a/ui/thumbnaillist.cpp +++ b/ui/thumbnaillist.cpp @@ -10,19 +10,20 @@ #include "thumbnaillist.h" // qt/kde includes -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include +#include +#include +#include #include +#include +#include +#include +#include +#include +#include + +#include +#include +#include // local includes #include "pagepainter.h" @@ -234,7 +235,7 @@ void ThumbnailList::notifySetup( const QVector< Okular::Page * > & pages, int se if ( !( setupFlags & Okular::DocumentObserver::DocumentChanged ) && d->m_selected ) { prevPage = d->m_selected->page()->number(); - } else + } else prevPage = d->m_document->viewport().pageNumber; // delete all the Thumbnails @@ -280,7 +281,7 @@ void ThumbnailList::notifySetup( const QVector< Okular::Page * > & pages, int se // restoring the previous selected page, if any if ( (*pIt)->number() < prevPage ) { - centerHeight = height + t->height() + KDialog::spacingHint()/2; + centerHeight = height + t->height() + this->style()->layoutSpacing(QSizePolicy::Frame, QSizePolicy::Frame, Qt::Vertical)/2; } if ( (*pIt)->number() == prevPage ) { @@ -288,11 +289,11 @@ void ThumbnailList::notifySetup( const QVector< Okular::Page * > & pages, int se d->m_selected->setSelected( true ); centerHeight = height + t->height() / 2; } - height += t->height() + KDialog::spacingHint(); + height += t->height() + this->style()->layoutSpacing(QSizePolicy::Frame, QSizePolicy::Frame, Qt::Vertical); } // update scrollview's contents size (sets scrollbars limits) - height -= KDialog::spacingHint(); + height -= this->style()->layoutSpacing(QSizePolicy::Frame, QSizePolicy::Frame, Qt::Vertical); widget()->resize( width, height ); // enable scrollbar when there's something to scroll @@ -395,7 +396,7 @@ bool ThumbnailList::canUnloadPixmap( int pageNumber ) const // if hidden permit unloading return true; } -//END DocumentObserver inherited methods +//END DocumentObserver inherited methods void ThumbnailList::updateWidgets() @@ -462,12 +463,12 @@ ThumbnailListPrivate::ChangePageDirection ThumbnailListPrivate::forwardTrack(con Okular::DocumentViewport vp = m_document->viewport(); const double deltaX = (double)point.x() / r.width(), deltaY = (double)point.y() / r.height(); - vp.rePos.normalizedX -= deltaX; + vp.rePos.normalizedX -= deltaX; vp.rePos.normalizedY -= deltaY; if ( vp.rePos.normalizedY > 1.0 ) return ThumbnailListPrivate::Down; if ( vp.rePos.normalizedY < 0.0 ) - return ThumbnailListPrivate::Up; + return ThumbnailListPrivate::Up; if ( vp.rePos.normalizedX > 1.0 ) return ThumbnailListPrivate::Right; if ( vp.rePos.normalizedX < 0.0 ) @@ -494,7 +495,7 @@ void ThumbnailList::slotFilterBookmarks( bool filterOn ) } -//BEGIN widget events +//BEGIN widget events void ThumbnailList::keyPressEvent( QKeyEvent * keyEvent ) { if ( d->m_thumbnails.count() < 1 ) @@ -570,11 +571,11 @@ void ThumbnailListPrivate::viewportResizeEvent( QResizeEvent * e ) ThumbnailWidget *t = *tIt; t->move(0, newHeight); t->resizeFitWidth( newWidth ); - newHeight += t->height() + KDialog::spacingHint(); + newHeight += t->height() + this->style()->layoutSpacing(QSizePolicy::Frame, QSizePolicy::Frame, Qt::Vertical); } // update scrollview's contents size (sets scrollbars limits) - newHeight -= KDialog::spacingHint(); + newHeight -= this->style()->layoutSpacing(QSizePolicy::Frame, QSizePolicy::Frame, Qt::Vertical); const int oldHeight = q->widget()->height(); const int oldYCenter = q->verticalScrollBar()->value() + q->viewport()->height() / 2; q->widget()->resize( newWidth, newHeight ); @@ -600,7 +601,7 @@ void ThumbnailListPrivate::viewportResizeEvent( QResizeEvent * e ) } //END widget events -//BEGIN internal SLOTS +//BEGIN internal SLOTS void ThumbnailListPrivate::slotRequestVisiblePixmaps( int /*newContentsY*/ ) { // if an update is already scheduled or the widget is hidden, don't proceed @@ -784,7 +785,7 @@ void ThumbnailListPrivate::mouseMoveEvent( QMouseEvent * e ) if ( !newThumb ) return; int newPageOn = newThumb->pageNumber(); - if ( newPageOn == m_pageCurrentlyGrabbed || newPageOn < 0 || + if ( newPageOn == m_pageCurrentlyGrabbed || newPageOn < 0 || newPageOn >= (int)m_document->pages() ) { return; @@ -798,8 +799,8 @@ void ThumbnailListPrivate::mouseMoveEvent( QMouseEvent * e ) if ( direction == ThumbnailListPrivate::Up ) { vp.rePos.normalizedY = 1.0; - if ( Okular::Settings::viewMode() == - Okular::Settings::EnumViewMode::FacingFirstCentered + if ( Okular::Settings::viewMode() == + Okular::Settings::EnumViewMode::FacingFirstCentered && !newPageOn) { if ( m_pageCurrentlyGrabbed == 1 ) @@ -815,8 +816,8 @@ void ThumbnailListPrivate::mouseMoveEvent( QMouseEvent * e ) else if ( direction == ThumbnailListPrivate::Down ) { vp.rePos.normalizedY = 0.0; - if ( Okular::Settings::viewMode() == - Okular::Settings::EnumViewMode::FacingFirstCentered + if ( Okular::Settings::viewMode() == + Okular::Settings::EnumViewMode::FacingFirstCentered && !m_pageCurrentlyGrabbed) { if ( origNormalX < 0.5 ) diff --git a/ui/thumbnaillist.h b/ui/thumbnaillist.h index ab50b044c..52460ba34 100644 --- a/ui/thumbnaillist.h +++ b/ui/thumbnaillist.h @@ -10,12 +10,12 @@ #ifndef _OKULAR_THUMBNAILLIST_H_ #define _OKULAR_THUMBNAILLIST_H_ -#include - -#include +#include +#include +#include #include "core/observer.h" -#include + class ThumbnailListPrivate; namespace Okular {