From e145f2797088ac40c68f1301c19303dff338d4df Mon Sep 17 00:00:00 2001 From: Albert Astals Cid Date: Sun, 26 Dec 2021 22:39:56 +0100 Subject: [PATCH] Fix uninitialized memory read when opening the settings ==25792== Conditional jump or move depends on uninitialised value(s) ==25792== at 0xFC1F7C2: PreferredScreenSelector::preferredScreen() const (dlgpresentation.cpp:215) ==25792== by 0xFC1F422: PreferredScreenSelector::repopulateList() (dlgpresentation.cpp:163) ==25792== by 0xFC1F23F: PreferredScreenSelector::PreferredScreenSelector(QWidget*) (dlgpresentation.cpp:151) ==25792== by 0xFC1EFBB: DlgPresentation::DlgPresentation(QWidget*) (dlgpresentation.cpp:128) ==25792== by 0xFC15825: PreferencesDialog::PreferencesDialog(QWidget*, KConfigSkeleton*, Okular::EmbedMode) (preferencesdialog.cpp:45) ==25792== by 0xFC4A522: Okular::Part::slotPreferences() (part.cpp:2834) --- part/dlgpresentation.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/part/dlgpresentation.cpp b/part/dlgpresentation.cpp index 364f7a859..04b065438 100644 --- a/part/dlgpresentation.cpp +++ b/part/dlgpresentation.cpp @@ -146,6 +146,7 @@ DlgPresentation::DlgPresentation(QWidget *parent) PreferredScreenSelector::PreferredScreenSelector(QWidget *parent) : QComboBox(parent) + , m_disconnectedScreenIndex(-1) , m_disconnectedScreenNumber(k_noDisconnectedScreenNumber) { repopulateList();