From de56b9c9c16544465c54ca2f90709d64481de903 Mon Sep 17 00:00:00 2001 From: Dileep Sankhla Date: Wed, 31 Jan 2018 10:54:37 -0700 Subject: [PATCH] Use correct arrow cursor for Annotations' close buttons Summary: When hovering the mouse over the X symbol to close a note the cursor remains the same of the current shape (hand, selection cursor) based on the tool selected. This patch morphe the cursor to the standard arrow over the X symbol to close a note by adding setCursor() call in the CloseButton constructor BUG: 384381 Test Plan: 1. Open okular and select Tools -> Review or press F6 to create a new pop-up note 2. Hover the mouse cursor over the close button (X) of the pop-up note window 3. You will see the standard arrow instead of the current tool based cursor. Screenshot below (the tooltip saying "Close this note" was not captured by Spectacle application) {F5685539} Reviewers: #okular, ngraham Reviewed By: ngraham Subscribers: ngraham, #okular Tags: #okular Differential Revision: https://phabricator.kde.org/D10209 --- ui/annotwindow.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/annotwindow.cpp b/ui/annotwindow.cpp index ab4e0cc5b..05ed9b7da 100644 --- a/ui/annotwindow.cpp +++ b/ui/annotwindow.cpp @@ -55,6 +55,7 @@ public: setIcon( style()->standardIcon( QStyle::SP_DockWidgetCloseButton ) ); setIconSize( size ); setToolTip( i18n( "Close this note" ) ); + setCursor( Qt::ArrowCursor ); } };