From c10faf0926e93cf410d08313d1d05e99f93b122d Mon Sep 17 00:00:00 2001 From: Albert Astals Cid Date: Thu, 20 Feb 2020 12:53:28 +0100 Subject: [PATCH] Enable clazy qproperty-without-notify --- .gitlab-ci.yml | 2 +- conf/dlgperformance.cpp | 1 - ui/ktreeviewsearchline.h | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index bf41027c6..ea559a594 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -48,7 +48,7 @@ build_clazy_clang_tidy: script: - srcdir=`pwd` && mkdir -p /tmp/okular_build && cd /tmp/okular_build && CC=clang CXX=clazy CXXFLAGS="-Werror -Wno-deprecated-declarations" cmake -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -G Ninja $srcdir && cat compile_commands.json | jq '[.[] | select(.file | contains("'"$srcdir"'"))]' > compile_commands.aux.json && cat compile_commands.aux.json | jq '[.[] | select(.file | contains("/synctex/")| not)]' > compile_commands.json - - CLAZY_CHECKS="level0,incorrect-emit,qhash-namespace,detaching-temporary,range-loop,qdeleteall,inefficient-qlist-soft,qstring-left,const-signal-or-slot,connect-3arg-lambda" ninja + - CLAZY_CHECKS="level0,incorrect-emit,qhash-namespace,detaching-temporary,range-loop,qdeleteall,inefficient-qlist-soft,qstring-left,const-signal-or-slot,connect-3arg-lambda,qproperty-without-notify" ninja # Fix the poppler header, remove when debian:unstable ships poppler 0.82 or later - sed -i "N;N;N;N; s#class MediaRendition\;\nclass MovieAnnotation\;\nclass ScreenAnnotation;#class MediaRendition\;#g" /usr/include/poppler/qt5/poppler-link.h - "run-clang-tidy -header-filter='.*/okular/.*' -checks='-*,performance-*,bugprone-*,readability-inconsistent-declaration-parameter-name,readability-string-compare,modernize-redundant-void-arg,modernize-use-bool-literals,modernize-make-unique,modernize-make-shared,modernize-use-override,modernize-use-equals-delete,modernize-use-emplace,modernize-loop-convert,modernize-use-nullptr,-bugprone-macro-parentheses,-bugprone-narrowing-conversions,-bugprone-branch-clone,-bugprone-incorrect-roundings' -config=\"{WarningsAsErrors: '*'}\"" diff --git a/conf/dlgperformance.cpp b/conf/dlgperformance.cpp index 1e1cc56ef..654c7d67c 100644 --- a/conf/dlgperformance.cpp +++ b/conf/dlgperformance.cpp @@ -20,7 +20,6 @@ DlgPerformance::DlgPerformance( QWidget * parent ) : QWidget( parent ) { - Q_PROPERTY( QButtonGroup checkedId READ checkedId USER true ); m_dlg = new Ui_DlgPerformanceBase(); m_dlg->setupUi( this ); diff --git a/ui/ktreeviewsearchline.h b/ui/ktreeviewsearchline.h index 0544115da..982922918 100644 --- a/ui/ktreeviewsearchline.h +++ b/ui/ktreeviewsearchline.h @@ -39,7 +39,7 @@ class KTreeViewSearchLine : public KLineEdit { Q_OBJECT - Q_PROPERTY( Qt::CaseSensitivity caseSensitity READ caseSensitivity WRITE setCaseSensitivity ) + Q_PROPERTY( Qt::CaseSensitivity caseSensitity READ caseSensitivity WRITE setCaseSensitivity NOTIFY searchOptionsChanged ) public: