From bc85160d7f2727b1911339a4bc1965f401d8fc2a Mon Sep 17 00:00:00 2001 From: Albert Astals Cid Date: Wed, 9 Dec 2020 21:37:32 +0100 Subject: [PATCH] clang-tidy: Disable performance-no-automatic-move It's just too aggressive with Qt classes that are refcounted and fine to copy --- .clang-tidy | 2 +- generators/dvi/dviFile.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index a2016be1c..8f8896f31 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -1,5 +1,5 @@ --- -Checks: 'clang-diagnostic-*,clang-analyzer-*,-*,performance-*,bugprone-*,readability-inconsistent-declaration-parameter-name,readability-string-compare,modernize-redundant-void-arg,modernize-use-bool-literals,modernize-make-unique,modernize-make-shared,modernize-use-override,modernize-use-equals-delete,modernize-use-emplace,modernize-loop-convert,modernize-use-nullptr,-bugprone-macro-parentheses,-bugprone-narrowing-conversions,-bugprone-branch-clone,-bugprone-incorrect-roundings,-bugprone-suspicious-include,-bugprone-reserved-identifier' +Checks: 'clang-diagnostic-*,clang-analyzer-*,-*,performance-*,bugprone-*,readability-inconsistent-declaration-parameter-name,readability-string-compare,modernize-redundant-void-arg,modernize-use-bool-literals,modernize-make-unique,modernize-make-shared,modernize-use-override,modernize-use-equals-delete,modernize-use-emplace,modernize-loop-convert,modernize-use-nullptr,-bugprone-macro-parentheses,-bugprone-narrowing-conversions,-bugprone-branch-clone,-bugprone-incorrect-roundings,-bugprone-suspicious-include,-bugprone-reserved-identifier,-performance-no-automatic-move' WarningsAsErrors: '*' HeaderFilterRegex: '.*/okular/.*' AnalyzeTemporaryDtors: false diff --git a/generators/dvi/dviFile.cpp b/generators/dvi/dviFile.cpp index 2faad3ac4..1e9b34e98 100644 --- a/generators/dvi/dviFile.cpp +++ b/generators/dvi/dviFile.cpp @@ -420,7 +420,7 @@ QString dvifile::convertPDFtoPS(const QString &PDFFilename, QString *converrorms convertedFiles[PDFFilename] = convertedFileName; tmpfile.setAutoRemove(false); - return convertedFileName; //// NOLINT(performance-no-automatic-move) QString is cheap to copy and we prefer the const safety + return convertedFileName; } bool dvifile::saveAs(const QString &filename)